Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xunit customer runner from tests, come up with a similar way to do the BDD style tests. #371

Closed
damianh opened this issue Sep 8, 2014 · 6 comments
Labels

Comments

@damianh
Copy link
Contributor

damianh commented Sep 8, 2014

Custom runner doesn't work in ncrunch and the whole API has change in xunit 2.0

@damianh damianh self-assigned this Sep 8, 2014
@damianh damianh added this to the v6.0.0 milestone Sep 8, 2014
@larsw
Copy link

larsw commented Jan 23, 2015

What about just using machine.specifications?

@andreabalducci
Copy link
Member

+1 all our bdd test on top of NES & our products are based on mspec, we are very satisfied.

@damianh damianh removed their assignment May 4, 2015
@kblooie
Copy link
Contributor

kblooie commented May 24, 2015

This project was actually using mspec and we moved away from it. The custom BDD code for XUnit was added to make it as close to the existing mspec tests as possible to simplify moving away from it.

I've used mspec for a while. The primary issue is that it's too easy to mess up and have hard to read buggy tests. You initialize one static field outside of a context and a group of tests fail... sometimes...

Also, in every project I've used it, there's been a ton of friction with on-boarding new devs. It's a unique way of writing tests that's not easy to understand at first.

I say we stick w/ XUnit and find a non-custom approach to BDD.

@andreabalducci
Copy link
Member

maybe was a bug on the previous versions, we have 700+ mspec tests on our current project without any issue.

@andreabalducci
Copy link
Member

@kblooie we need to run the persistence tests with different options for a given provider (eg: mongo with or without server side checkpoint), there's a simple way to do this with current test framework?

@alkampfergit alkampfergit removed this from the v6.0.0 milestone Jul 12, 2016
@AGiorgetti
Copy link
Member

Changed how testing works: created some support classes so we can chose between XUnit, NUnit or MSTests.
Actually NUnit is configured via build constants in csproj files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants