Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: PupupService): fix when using multiple PupupService working error #292

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

Guoyuanqiang
Copy link
Member

…ng error

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #292 into master will decrease coverage by 0.02%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
- Coverage   89.95%   89.92%   -0.03%     
==========================================
  Files         228      228              
  Lines        6820     6831      +11     
  Branches      550      551       +1     
==========================================
+ Hits         6135     6143       +8     
- Misses        522      525       +3     
  Partials      163      163
Impacted Files Coverage Δ
components/modal/modal.service.ts 70.45% <0%> (ø) ⬆️
components/action-sheet/action-sheet.service.ts 84.31% <100%> (ø) ⬆️
components/picker/picker.service.ts 94.44% <100%> (ø) ⬆️
components/core/services/popup.service.ts 83.87% <73.33%> (-6.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86be97d...026acfd. Read the comment docs.

@fisherspy fisherspy merged commit 3717db7 into NG-ZORRO:master Feb 25, 2019
@Guoyuanqiang Guoyuanqiang deleted the popup branch March 14, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants