perf(module:typography, tabs): make the destroy$ complete when dest…

…roy (#4271)
NG-ZORRO · Oct 11, 2019 · 51f4713 · 51f4713
1 parent e9c5541
commit 51f4713
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/components/tabs/nz-tabset.component.ts b/components/tabs/nz-tabset.component.ts
@@ -308,6 +308,8 @@ export class NzTabSetComponent
   ngOnDestroy(): void {
     this.tabsSubscription.unsubscribe();
     this.tabLabelSubscription.unsubscribe();
+    this.destroy$.next();
+    this.destroy$.complete();
   }
 
   ngAfterViewInit(): void {

diff --git a/components/typography/nz-text-copy.component.ts b/components/typography/nz-text-copy.component.ts
@@ -59,6 +59,8 @@ export class NzTextCopyComponent implements OnInit, OnDestroy {
 
   ngOnDestroy(): void {
     clearTimeout(this.copyId);
+    this.destroy$.next();
+    this.destroy$.complete();
   }
 
   onClick(): void {