Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal afterClose observable never completes #2749

Closed
dnbo opened this issue Jan 7, 2019 · 1 comment
Closed

Modal afterClose observable never completes #2749

dnbo opened this issue Jan 7, 2019 · 1 comment
Assignees
Labels
Component: Modal 👨‍🏭 Some one working on this A community member has started working on this

Comments

@dnbo
Copy link

dnbo commented Jan 7, 2019

Version

7.0.0-rc.3

Environment

Mac OS

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-start-hfcdxp

Steps to reproduce

Pipe an observable array of objects into a concatMap to open a modal for each object in sequence. Return the Observable<any> from the modalRef.afterClose function to the outer observable. The inner observable afterClose never completes.

What is expected?

The inner observable to complete.

What is actually happening?

The inner observable never completes.

Other?

Work around

Piping the afterClose to take(1) to force source.complete to be called.

@dnbo dnbo changed the title Modal afterClose observable breaks stream / never completes Modal afterClose observable never completes Jan 7, 2019
@atxkm
Copy link

atxkm commented Oct 11, 2019

已经8.0了,没有解决,没法用 await afterClose

@hsuanxyz hsuanxyz added the 👨‍🏭 Some one working on this A community member has started working on this label Jan 16, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Jan 19, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Feb 3, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
* refactor(module:modal): refactor the modal service

close NG-ZORRO#3652, close NG-ZORRO#4437, close NG-ZORRO#2749

* feat(module:modal): support autofocus

close NG-ZORRO#3423, close NG-ZORRO#4126

* refactor(module:modal): refactor the modal component

* chore: rename files

* test(module:modal): add test case

* test(module:modal): add test case

* feat(module:modal): support nzCloseOnNavigation

* feat(module:modal): support nzViewContainerRef

close NG-ZORRO#4710

test(module:modal): add footer directive test

test(module:modal): add callback test

test(module:modal): add animation test

test(module:modal): add classname and styles test

test(module:modal): add footer component test

test(module:modal): fix test

test(module:modal): fix test

test(module:modal): add confirm test

test(module:modal): fix test

test(module:modal): add component mode test

chore: remove console

test: fix ci test
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
* refactor(module:modal): refactor the modal service

close NG-ZORRO#3652, close NG-ZORRO#4437, close NG-ZORRO#2749

* feat(module:modal): support autofocus

close NG-ZORRO#3423, close NG-ZORRO#4126

* refactor(module:modal): refactor the modal component

* chore: rename files

* test(module:modal): add test case

* test(module:modal): add test case

* feat(module:modal): support nzCloseOnNavigation

* feat(module:modal): support nzViewContainerRef

close NG-ZORRO#4710

test(module:modal): add footer directive test

test(module:modal): add callback test

test(module:modal): add animation test

test(module:modal): add classname and styles test

test(module:modal): add footer component test

test(module:modal): fix test

test(module:modal): fix test

test(module:modal): add confirm test

test(module:modal): fix test

test(module:modal): add component mode test

chore: remove console

test: fix ci test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Modal 👨‍🏭 Some one working on this A community member has started working on this
Projects
None yet
Development

No branches or pull requests

4 participants