Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExpressionChangedAfterItHasBeenCheckedError when modal destroy #3652

Closed
drodreo opened this issue Jun 25, 2019 · 0 comments
Closed

ExpressionChangedAfterItHasBeenCheckedError when modal destroy #3652

drodreo opened this issue Jun 25, 2019 · 0 comments
Assignees
Labels
Component: Modal 👨‍🏭 Some one working on this A community member has started working on this

Comments

@drodreo
Copy link

drodreo commented Jun 25, 2019

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-problem-reproduce-1

Steps to reproduce

  1. Click Open Editor
  2. Click Submit
  3. Check about the console output

What is expected?

Modal should closed correctly

What is actually happening?

got exception:
ERROR
Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value: 'ngClass: null'. Current value: 'ngClass: [object Object]'.

Environment Info
ng-zorro-antd 7.3.0
Browser Chrome Version 75.0.3770.100 (Official Build) (64-bit)
@hsuanxyz hsuanxyz added the 👨‍🏭 Some one working on this A community member has started working on this label Jan 16, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Jan 19, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Feb 3, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
* refactor(module:modal): refactor the modal service

close NG-ZORRO#3652, close NG-ZORRO#4437, close NG-ZORRO#2749

* feat(module:modal): support autofocus

close NG-ZORRO#3423, close NG-ZORRO#4126

* refactor(module:modal): refactor the modal component

* chore: rename files

* test(module:modal): add test case

* test(module:modal): add test case

* feat(module:modal): support nzCloseOnNavigation

* feat(module:modal): support nzViewContainerRef

close NG-ZORRO#4710

test(module:modal): add footer directive test

test(module:modal): add callback test

test(module:modal): add animation test

test(module:modal): add classname and styles test

test(module:modal): add footer component test

test(module:modal): fix test

test(module:modal): fix test

test(module:modal): add confirm test

test(module:modal): fix test

test(module:modal): add component mode test

chore: remove console

test: fix ci test
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
* refactor(module:modal): refactor the modal service

close NG-ZORRO#3652, close NG-ZORRO#4437, close NG-ZORRO#2749

* feat(module:modal): support autofocus

close NG-ZORRO#3423, close NG-ZORRO#4126

* refactor(module:modal): refactor the modal component

* chore: rename files

* test(module:modal): add test case

* test(module:modal): add test case

* feat(module:modal): support nzCloseOnNavigation

* feat(module:modal): support nzViewContainerRef

close NG-ZORRO#4710

test(module:modal): add footer directive test

test(module:modal): add callback test

test(module:modal): add animation test

test(module:modal): add classname and styles test

test(module:modal): add footer component test

test(module:modal): fix test

test(module:modal): fix test

test(module:modal): add confirm test

test(module:modal): fix test

test(module:modal): add component mode test

chore: remove console

test: fix ci test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Modal 👨‍🏭 Some one working on this A community member has started working on this
Projects
None yet
Development

No branches or pull requests

2 participants