fix(module:table): fix table crash with double binding #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit 07fbfa0 |
Codecov Report
@@ Coverage Diff @@
## master #3007 +/- ##
=======================================
Coverage 97.35% 97.35%
=======================================
Files 550 550
Lines 11452 11452
Branches 813 815 +2
=======================================
Hits 11149 11149
Misses 190 190
Partials 113 113
Continue to review full report at Codecov.
|
wzhudev
reviewed
Mar 1, 2019
components/table/nz-table.spec.ts
Outdated
| @@ -294,6 +294,19 @@ describe('nz-table', () => { | |||
| expect(tableBody.scrollWidth).toBe(tableBody.clientWidth); | |||
| }); | |||
| }); | |||
| describe('crash nz-table', () => { | |||
There was a problem hiding this comment.
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3004
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information