Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: tree): fix nzMultiple and rollback code #3060

Merged
merged 9 commits into from
Mar 21, 2019

Conversation

simplejason
Copy link
Member

@simplejason simplejason commented Mar 11, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3076

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Mar 11, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 8514b5f

https://deploy-preview-3060--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #3060 into master will increase coverage by 0.03%.
The diff coverage is 96.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3060      +/-   ##
==========================================
+ Coverage    97.3%   97.34%   +0.03%     
==========================================
  Files         550      552       +2     
  Lines       11539    11587      +48     
  Branches      826      827       +1     
==========================================
+ Hits        11228    11279      +51     
+ Misses        201      195       -6     
- Partials      110      113       +3
Impacted Files Coverage Δ
components/tree/nz-tree-node.component.ts 97.14% <ø> (+0.44%) ⬆️
components/tree/nz-tree.module.ts 100% <ø> (ø) ⬆️
components/tree/public-api.ts 100% <100%> (ø) ⬆️
components/tree/nz-tree-node.ts 91.72% <91.93%> (+2.74%) ⬆️
components/tree/nz-tree-base.service.ts 96.77% <98.21%> (-0.11%) ⬇️
components/tree/nz-tree.component.ts 98.77% <98.63%> (-0.66%) ⬇️
components/cascader/types.ts
components/cascader/nz-cascader-definitions.ts 100% <0%> (ø)
components/cascader/nz-cascader.service.ts 98.87% <0%> (ø)
components/cascader/nz-cascader-utils.ts 100% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b3465...8514b5f. Read the comment docs.

@simplejason simplejason force-pushed the fix-tree-bug branch 2 times, most recently from 24c66dd to b291c17 Compare March 11, 2019 09:16
components/tree/nz-tree.module.ts Outdated Show resolved Hide resolved
components/tree/nz-tree.component.ts Outdated Show resolved Hide resolved
@simplejason simplejason merged commit c917938 into NG-ZORRO:master Mar 21, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* fix(module: tree): fix nzMultiple and rollback code

* fix(module: tree): fix spec and export service

fix(module: tree): fix doc

* fix(module: tree): fix code bug

* fix(module: tree): fix treeService error and code merge

* fix(module: tree): fix strict code style

* fix(module: tree): fix strict spec code

* fix(module: tree): remove unnecessary demo code

* fix(module: tree): fix doc and demo

* fix(module: tree): add notice doc

close NG-ZORRO#3076
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix(module: tree): fix nzMultiple and rollback code

* fix(module: tree): fix spec and export service

fix(module: tree): fix doc

* fix(module: tree): fix code bug

* fix(module: tree): fix treeService error and code merge

* fix(module: tree): fix strict code style

* fix(module: tree): fix strict spec code

* fix(module: tree): remove unnecessary demo code

* fix(module: tree): fix doc and demo

* fix(module: tree): add notice doc

close NG-ZORRO#3076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants