build: add secondary entries #3234

wzhudev · 2019-04-08T07:45:20Z

close #700

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes: support both `NgZorroAntdModule` and secondary modules
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #700

Users could only import NgZorroAntdModule to their modules, thus bundles are not optimized enough for projects that only use several the components.

What is the new behavior?

Secondary modules and entries are available now. Say a user only wants to render a NzButton on the screen, he can import NzButtonModule instead of `NgZorroAntdModule. Building is faster and the bundle's size is reduced from 432KB to 242KB.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

wzhudev · 2019-04-09T08:40:11Z

Circular imports

These modules have circular imports:

menu & dropdown (solved)
tree & tree-select (solved)

Reasons for circular imports are the same: component B wants to know if it's wrapped in component A:

Tree wants to know if it's in a tree-select.
Menu wants to know if it's in a dropdown.

CSS

Now we will compile style for each component.
Other basic of shared styles are compiled to style/index.css.

Official website

Now the official website built on netlify for preview purpose is built from the source code of the components.

netlify · 2019-04-11T08:43:57Z

Deploy preview for ng-zorro-master ready!

Built with commit 3982d19

https://deploy-preview-3234--ng-zorro-master.netlify.com

codecov · 2019-04-12T05:46:24Z

Codecov Report

Merging #3234 into master will increase coverage by <.01%.
The diff coverage is 99.16%.

@@            Coverage Diff             @@
##           master    #3234      +/-   ##
==========================================
+ Coverage   97.51%   97.52%   +<.01%     
==========================================
  Files         562      607      +45     
  Lines       11852    11864      +12     
  Branches      866      867       +1     
==========================================
+ Hits        11558    11570      +12     
  Misses        183      183              
  Partials      111      111

Impacted Files	Coverage Δ
components/dropdown/nz-dropdown.service.ts	`100% <ø> (ø)`	⬆️
components/date-picker/lib/util.ts	`100% <ø> (ø)`	⬆️
...omponents/date-picker/lib/candy-date/candy-date.ts	`100% <ø> (ø)`	⬆️
components/cascader/nz-cascader-li.component.ts	`94.44% <ø> (ø)`	⬆️
components/core/util/check.ts	`91.66% <ø> (ø)`	⬆️
...nts/core/no-animation/nz-no-animation.directive.ts	`95.23% <ø> (ø)`	⬆️
components/core/logger/logger.service.ts	`72.22% <ø> (ø)`
components/core/tree/nz-tree-base-node.ts	`93.38% <ø> (ø)`
...ts/date-picker/lib/calendar/ok-button.component.ts	`100% <ø> (ø)`	⬆️
components/core/testing/public-api.ts	`100% <ø> (ø)`	⬆️
... and 228 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4bde4...3982d19. Read the comment docs.

docs/getting-started.zh-CN.md

hsuanxyz · 2019-04-13T13:52:43Z

@vthinkxie stackblitz 能改成按需引入吗？这样可能会提高加载速度，也许还能暴露一些 bug，可以先发 next 测试一下

vthinkxie · 2019-04-13T14:49:09Z

@vthinkxie stackblitz 能改成按需引入吗？这样可能会提高加载速度，也许还能暴露一些 bug，可以先发 next 测试一下

可以的，你们先review完，我这边还有一些工作，合并完之后可以先发next

hsuanxyz

~~avatar 组件 .spec.ts 文件改漏了~~

hsuanxyz

core/style/index.less 也需要编译，并且在【快速上手/二级入口】中说明，因为里面对有些组件样式进行了覆盖。

components/tree-select/nz-tree-select.service.js

components/tree/interface.ts

components/pagination/doc/index.zh-CN.md

components/dropdown/doc/index.zh-CN.md

close NG-ZORRO#700 fix: fix imports in components and specs fix: circular import of tree and tree-select fix(module:menu,dropdown): fix circular import fix(module:*): fix imports build: fix build build: fix primary important docs: fix doc site build fix: build build: add css secondary entries docs: update doc fix: imports in tests fix: fix updatehostservice in submenu component docs: change docs on gettings started docs: specify version fix: fix styles and update docs docs: update docs fix: fix tooltip and patch files build: fix primary entry fix: core export bug fix: fix nz_i18n injection error fix: fix dropdownservice provide position fix: fix missing import docs: fix CONTRIBUTING.md fix

* build: add secondary entries close NG-ZORRO#700 fix: fix imports in components and specs fix: circular import of tree and tree-select fix(module:menu,dropdown): fix circular import fix(module:*): fix imports build: fix build build: fix primary important docs: fix doc site build fix: build build: add css secondary entries docs: update doc fix: imports in tests fix: fix updatehostservice in submenu component docs: change docs on gettings started docs: specify version fix: fix styles and update docs docs: update docs fix: fix tooltip and patch files build: fix primary entry fix: core export bug fix: fix nz_i18n injection error fix: fix dropdownservice provide position fix: fix missing import docs: fix CONTRIBUTING.md fix * fix: fix import in breadcrumb * fix: some lint * fix: some lint * fix: less import in component.less * docs: fix some docs * docs: notice ngzorroantdmodule

wzhudev assigned wzhudev, vthinkxie, simplejason and hsuanxyz Apr 9, 2019

wzhudev force-pushed the secondary-entry branch from 803c5d7 to 8e51b77 Compare April 11, 2019 07:02

wzhudev marked this pull request as ready for review April 12, 2019 02:54

wzhudev force-pushed the secondary-entry branch from 2e90d53 to 789d532 Compare April 12, 2019 02:59

wzhudev added PR::eyes: Need Review 🖨 Build labels Apr 12, 2019

hsuanxyz reviewed Apr 13, 2019

View reviewed changes

docs/getting-started.zh-CN.md Outdated Show resolved Hide resolved

docs/getting-started.zh-CN.md Outdated Show resolved Hide resolved

vthinkxie mentioned this pull request Apr 13, 2019

Unable to build in Production #3266

Closed

hsuanxyz reviewed Apr 15, 2019

View reviewed changes

hsuanxyz requested changes Apr 15, 2019

View reviewed changes

components/tree-select/nz-tree-select.service.js Outdated Show resolved Hide resolved

components/tree/interface.ts Outdated Show resolved Hide resolved

wzhudev mentioned this pull request Apr 15, 2019

has conflict with material-table-component #2398

Closed

vthinkxie mentioned this pull request Apr 15, 2019

MILESTONE: EARLY 2019 #2474

Closed

12 tasks

wzhudev force-pushed the secondary-entry branch from a504b55 to 093d291 Compare April 16, 2019 03:06

wzhudev requested a review from hsuanxyz April 16, 2019 08:37

wzhudev force-pushed the secondary-entry branch from d53eb47 to bbdf0e6 Compare April 16, 2019 09:12

hsuanxyz reviewed Apr 17, 2019

View reviewed changes

components/pagination/doc/index.zh-CN.md Show resolved Hide resolved

vthinkxie unassigned vthinkxie and simplejason Apr 17, 2019

hsuanxyz reviewed Apr 17, 2019

View reviewed changes

components/dropdown/doc/index.zh-CN.md Show resolved Hide resolved

wzhudev force-pushed the secondary-entry branch 3 times, most recently from c443b15 to ba28816 Compare April 18, 2019 11:40

Wendell added 6 commits April 19, 2019 11:27

fix: fix import in breadcrumb

c58e341

fix: some lint

4a1bda8

fix: some lint

da96a87

fix: less import in component.less

5b6fd1e

docs: fix some docs

4068e5b

wzhudev force-pushed the secondary-entry branch from 32b5c0c to 4068e5b Compare April 19, 2019 03:27

docs: notice ngzorroantdmodule

3982d19

hsuanxyz approved these changes Apr 19, 2019

View reviewed changes

hsuanxyz merged commit 53724be into NG-ZORRO:master Apr 19, 2019

wzhudev deleted the secondary-entry branch April 20, 2019 02:27

wzhudev mentioned this pull request May 8, 2019

consider to reduce size of final css file? #2397

Closed

hsuanxyz removed PR::eyes: Need Review labels Jun 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: add secondary entries #3234

build: add secondary entries #3234

wzhudev commented Apr 8, 2019 •

edited

Loading

wzhudev commented Apr 9, 2019 •

edited

Loading

netlify bot commented Apr 11, 2019 •

edited

Loading

codecov bot commented Apr 12, 2019 •

edited

Loading

hsuanxyz commented Apr 13, 2019

vthinkxie commented Apr 13, 2019

hsuanxyz left a comment •

edited

Loading

hsuanxyz left a comment

build: add secondary entries #3234

build: add secondary entries #3234

Conversation

wzhudev commented Apr 8, 2019 • edited Loading

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

wzhudev commented Apr 9, 2019 • edited Loading

Circular imports

CSS

Official website

netlify bot commented Apr 11, 2019 • edited Loading

codecov bot commented Apr 12, 2019 • edited Loading

Codecov Report

hsuanxyz commented Apr 13, 2019

vthinkxie commented Apr 13, 2019

hsuanxyz left a comment • edited Loading

Choose a reason for hiding this comment

hsuanxyz left a comment

Choose a reason for hiding this comment

wzhudev commented Apr 8, 2019 •

edited

Loading

wzhudev commented Apr 9, 2019 •

edited

Loading

netlify bot commented Apr 11, 2019 •

edited

Loading

codecov bot commented Apr 12, 2019 •

edited

Loading

hsuanxyz left a comment •

edited

Loading