Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tree, tree-select): fix the key validity check #3247

Merged
merged 2 commits into from
Apr 17, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3163

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Apr 10, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 6290a60

https://deploy-preview-3247--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #3247 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3247      +/-   ##
==========================================
+ Coverage   97.37%   97.39%   +0.01%     
==========================================
  Files         559      559              
  Lines       11627    11627              
  Branches      835      834       -1     
==========================================
+ Hits        11322    11324       +2     
  Misses        193      193              
+ Partials      112      110       -2
Impacted Files Coverage Δ
components/tree/nz-tree-node.ts 93.38% <100%> (+1.47%) ⬆️
components/tree-select/nz-tree-select.component.ts 99.48% <100%> (ø) ⬆️
components/tree/nz-tree-base.service.ts 97.16% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c0d53...6290a60. Read the comment docs.

@vthinkxie vthinkxie merged commit 87f2386 into NG-ZORRO:master Apr 17, 2019
@hsuanxyz hsuanxyz deleted the fix/tree-select-key branch April 22, 2019 02:39
andrew-yangy pushed a commit to andrew-yangy/ng-zorro-antd that referenced this pull request Jun 20, 2019
)

* fix(module:tree, tree-select): fix the key validity check

close NG-ZORRO#3163

* fix(module:tree, tree-select): fix the key validity check
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
)

* fix(module:tree, tree-select): fix the key validity check

close NG-ZORRO#3163

* fix(module:tree, tree-select): fix the key validity check
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
)

* fix(module:tree, tree-select): fix the key validity check

close NG-ZORRO#3163

* fix(module:tree, tree-select): fix the key validity check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants