Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tabs): support link router #3718

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jul 3, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@wzhudev
Copy link
Member Author

wzhudev commented Jul 3, 2019

Working on tests... 🤗

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #3718 into master will decrease coverage by <.01%.
The diff coverage is 93.18%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3718      +/-   ##
=========================================
- Coverage    95.4%   95.4%   -0.01%     
=========================================
  Files         711     712       +1     
  Lines       14593   14632      +39     
  Branches     1924    1929       +5     
=========================================
+ Hits        13923   13959      +36     
- Misses        243     244       +1     
- Partials      427     429       +2
Impacted Files Coverage Δ
components/tabs/nz-tabs.module.ts 100% <100%> (ø) ⬆️
components/tabs/nz-tab.component.ts 96.55% <100%> (+0.55%) ⬆️
components/tabs/public-api.ts 100% <100%> (ø) ⬆️
components/tabs/nz-tab-link.directive.ts 100% <100%> (ø)
components/tabs/nz-tabset.component.ts 93.19% <90.32%> (-0.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42e9e14...2a5969f. Read the comment docs.

@wzhudev wzhudev mentioned this pull request Jul 3, 2019
8 tasks
@netlify
Copy link

netlify bot commented Jul 3, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 2a5969f

https://deploy-preview-3718--ng-zorro-master.netlify.com

@lppedd
Copy link
Contributor

lppedd commented Jul 3, 2019

@wendzhue Thank you for this one!
I'm using un ugly workaround now, finally I can remove it.

components/tabs/nz-tab.component.ts Outdated Show resolved Hide resolved
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tryActivateLink should be removed, routerChange should base on a link href

components/tabs/nz-tabset.component.ts Outdated Show resolved Hide resolved
components/tabs/demo/link-router.ts Outdated Show resolved Hide resolved
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit ab8a58c into NG-ZORRO:master Jul 18, 2019
@wzhudev wzhudev deleted the tabs-navigation branch July 19, 2019 03:18
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants