Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:result): add component #3731

Merged
merged 12 commits into from
Jul 19, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jul 4, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Jul 4, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 5d6efd6

https://deploy-preview-3731--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jul 4, 2019

Codecov Report

Merging #3731 into master will decrease coverage by <.01%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3731      +/-   ##
=========================================
- Coverage    95.4%   95.4%   -0.01%     
=========================================
  Files         711     719       +8     
  Lines       14593   14650      +57     
  Branches     1924    1927       +3     
=========================================
+ Hits        13923   13977      +54     
  Misses        243     243              
- Partials      427     430       +3
Impacted Files Coverage Δ
components/ng-zorro-antd.module.ts 98.47% <100%> (+0.02%) ⬆️
components/result/public-api.ts 100% <100%> (ø)
components/test.ts 81.81% <100%> (-2.8%) ⬇️
components/result/nz-result-cells.ts 100% <100%> (ø)
components/result/index.ts 100% <100%> (ø)
components/result/partial/unauthorized.ts 100% <100%> (ø)
...omponents/result/partial/server-error.component.ts 100% <100%> (ø)
components/result/partial/not-found.ts 100% <100%> (ø)
components/result/nz-result.module.ts 100% <100%> (ø)
components/result/nz-result.component.ts 92.3% <92.3%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42e9e14...5d6efd6. Read the comment docs.

@wzhudev wzhudev merged commit eb6377e into NG-ZORRO:master Jul 19, 2019
@pr-triage pr-triage bot added the PR: merged label Jul 19, 2019
@wzhudev wzhudev deleted the new-component-result branch July 19, 2019 03:18
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants