Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:dropdown): allow backdrop to be disabled #3769

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

lppedd
Copy link
Contributor

@lppedd lppedd commented Jul 11, 2019

Needs someone that translate the documentation to Chinese, I'm afraid I cannot 😄
See "current behavior" for explanation.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Currently the backdrop is enforced when using trigger = 'click'.
This causes usability problems when used in conjunction, for example, with a custom table filter.

What is the new behavior?

The backdrop can be disabled by setting nzBackdrop = false.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@netlify
Copy link

netlify bot commented Jul 11, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 5d106ca

https://deploy-preview-3769--ng-zorro-master.netlify.com

@wzhudev wzhudev requested a review from vthinkxie July 11, 2019 08:01
@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #3769 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3769      +/-   ##
==========================================
+ Coverage   95.38%   95.38%   +<.01%     
==========================================
  Files         706      706              
  Lines       14506    14508       +2     
  Branches     1913     1914       +1     
==========================================
+ Hits        13836    13839       +3     
  Misses        243      243              
+ Partials      427      426       -1
Impacted Files Coverage Δ
components/dropdown/nz-dropdown.directive.ts 89.09% <100%> (+0.13%) ⬆️
components/select/nz-option-container.component.ts 97.67% <0%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3847250...5d106ca. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR

@lppedd
Copy link
Contributor Author

lppedd commented Jul 15, 2019

@vthinkxie my pleasure. Fixed documentation. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants