Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): update copy-resources script to support Windows path #3856

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

gnastnosaj
Copy link
Contributor

@gnastnosaj gnastnosaj commented Jul 24, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

schematic resources not copied correctly in windows.

What is the new behavior?

schematic resources copied correctly in windows.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jul 24, 2019

Deploy preview for ng-zorro-master ready!

Built with commit f889580

https://deploy-preview-3856--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #3856 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3856   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files         723      723           
  Lines       14722    14722           
  Branches     1937     1937           
=======================================
  Hits        14040    14040           
  Misses        249      249           
  Partials      433      433

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4de8ff...f889580. Read the comment docs.

@wzhudev wzhudev requested a review from hsuanxyz July 24, 2019 09:14
@hsuanxyz hsuanxyz changed the title fix(schematics): update copy-resources script to support windows path. fix(schematics): update copy-resources script to support Windows path. Jul 26, 2019
@hsuanxyz hsuanxyz changed the title fix(schematics): update copy-resources script to support Windows path. fix(schematics): update copy-resources script to support Windows path Jul 26, 2019
@hsuanxyz hsuanxyz merged commit 915b67d into NG-ZORRO:master Jul 26, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants