Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tooltip): fix position change not set back #3857

Merged
merged 2 commits into from
Jul 28, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jul 24, 2019

close #3467

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3467

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jul 24, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 6c50450

https://deploy-preview-3857--ng-zorro-master.netlify.com

@wzhudev wzhudev requested a review from hsuanxyz July 24, 2019 09:30
@netlify
Copy link

netlify bot commented Jul 24, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 9f594da

https://deploy-preview-3857--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #3857 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3857      +/-   ##
==========================================
- Coverage   95.36%   95.36%   -0.01%     
==========================================
  Files         723      723              
  Lines       14722    14722              
  Branches     1937     1937              
==========================================
- Hits        14040    14039       -1     
  Misses        249      249              
- Partials      433      434       +1
Impacted Files Coverage Δ
components/tooltip/nz-tooltip.component.ts 88.88% <100%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4de8ff...9f594da. Read the comment docs.

@hsuanxyz hsuanxyz requested review from vthinkxie and removed request for hsuanxyz July 26, 2019 09:52
@hsuanxyz hsuanxyz assigned vthinkxie and unassigned hsuanxyz Jul 26, 2019
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chensimeng chensimeng merged commit 3dbb6dc into NG-ZORRO:master Jul 28, 2019
@wzhudev wzhudev deleted the fix-tooltip-scroll branch August 9, 2019 04:10
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* fix(module:tooltip): fix position change not set back

* revert: revert to detectChanges to avoid blinking
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix(module:tooltip): fix position change not set back

* revert: revert to detectChanges to avoid blinking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Popconfirm' Position Error When Scrolling
4 participants