Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nz-tab-link active router check should not only be exact #3858

Closed
Yezuz05 opened this issue Jul 24, 2019 · 2 comments

Comments

@Yezuz05
Copy link

commented Jul 24, 2019

What problem does this feature solve?

The current check for active route is exact, which doesn't set the active tab when in a child route.

What does the proposed API look like?

<a nz-tab-link [routerLink]="['./route']" queryParamsHandling="preserve" [nzExactActiveRouteCheck]="false">link

@wendzhue

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

We will make this optional. Because if it's false, users cannot use it with query params.

@Yezuz05

This comment has been minimized.

Copy link
Author

commented Jul 24, 2019

@wendzhue Yeah, I meant optional, false was just an example :)

wendzhue added a commit to wendzhue/ng-zorro-antd that referenced this issue Jul 25, 2019

wendzhue added a commit that referenced this issue Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.