Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nz-tab-link active router check should not only be exact #3858

Closed
Yezuz05 opened this issue Jul 24, 2019 · 2 comments · Fixed by #3862
Closed

nz-tab-link active router check should not only be exact #3858

Yezuz05 opened this issue Jul 24, 2019 · 2 comments · Fixed by #3862
Assignees
@wzhudev
Labels
Component: Tabs 💪 Enhancement

Comments

@Yezuz05
Copy link

Yezuz05 commented Jul 24, 2019

What problem does this feature solve?

The current check for active route is exact, which doesn't set the active tab when in a child route.

What does the proposed API look like?

<a nz-tab-link [routerLink]="['./route']" queryParamsHandling="preserve" [nzExactActiveRouteCheck]="false">link
@vthinkxie vthinkxie assigned wzhudev and unassigned vthinkxie Jul 24, 2019
@wzhudev
Copy link
Member

wzhudev commented Jul 24, 2019

We will make this optional. Because if it's false, users cannot use it with query params.

@Yezuz05
Copy link
Author

Yezuz05 commented Jul 24, 2019 •
edited
Loading

@wendzhue Yeah, I meant optional, false was just an example :)

wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Jul 25, 2019
feat(module:tabs): add router exact active parameter
4981eb9 
close NG-ZORRO#3858
@wzhudev wzhudev mentioned this issue Jul 25, 2019
Merged
3 tasks
wzhudev pushed a commit that referenced this issue Aug 9, 2019
feat(module:tabs): add router exact active parameter (#3862)
6b13faf 
close #3858
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@Ricbet
feat(module:tabs): add router exact active parameter (NG-ZORRO#3862)
ee8a9bb 
close NG-ZORRO#3858
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
feat(module:tabs): add router exact active parameter (NG-ZORRO#3862)
467cf0e 
close NG-ZORRO#3858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wzhudev wzhudev

Labels
Component: Tabs 💪 Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(module:tabs): add router exact active parameter wzhudev/ng-zorro-antd
3 participants
@vthinkxie @wzhudev @Yezuz05