Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tabs): add router exact active parameter #3862

Merged
merged 2 commits into from
Aug 9, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jul 25, 2019

close #3858

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3858

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jul 25, 2019

Deploy preview for ng-zorro-master ready!

Built with commit f2b4a06

https://deploy-preview-3862--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #3862 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3862      +/-   ##
==========================================
- Coverage   95.36%   95.24%   -0.13%     
==========================================
  Files         723      726       +3     
  Lines       14722    14668      -54     
  Branches     1937     1910      -27     
==========================================
- Hits        14040    13970      -70     
- Misses        249      260      +11     
- Partials      433      438       +5
Impacted Files Coverage Δ
components/tabs/nz-tabset.component.ts 93.19% <100%> (ø) ⬆️
components/form/nz-form-item.component.ts 86.84% <0%> (-10.04%) ⬇️
components/tooltip/nz-tooltip.component.ts 88.88% <0%> (-1.59%) ⬇️
components/tabs/nz-tabs-nav.component.ts 89.88% <0%> (-1.08%) ⬇️
components/date-picker/header-picker.component.ts 97.05% <0%> (-0.09%) ⬇️
components/back-top/nz-back-top.module.ts 100% <0%> (ø) ⬆️
...te-picker/lib/popups/date-range-popup.component.ts 95.3% <0%> (ø) ⬆️
components/avatar/nz-avatar.module.ts 100% <0%> (ø) ⬆️
components/statistic/nz-statistic.module.ts 100% <0%> (ø) ⬆️
...nents/date-picker/lib/year/year-panel.component.ts 98.3% <0%> (ø) ⬆️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4de8ff...f2b4a06. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs markdown error

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 6b13faf into NG-ZORRO:master Aug 9, 2019
@wzhudev wzhudev deleted the tabs-router-link-exact branch August 9, 2019 06:49
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-tab-link active router check should not only be exact
2 participants