Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor tooltip components #3909

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 1, 2019

close #3456

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

TODO

  • Use titles with prefix (like nzTooltipTitle) and deprecate old ones without prefix
  • Typing things
  • And new api for positions and trigger, too.
  • Add deprecation information.

Component usage will be removed in 9.0.0.

API without prefix will be removed in 10.0.0.

@pr-triage pr-triage bot added the PR: draft label Aug 1, 2019
@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@ffb7219). Click here to learn what that means.
The diff coverage is 94.46%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3909   +/-   ##
========================================
  Coverage          ?   95.3%           
========================================
  Files             ?     782           
  Lines             ?   14924           
  Branches          ?    1930           
========================================
  Hits              ?   14223           
  Misses            ?     263           
  Partials          ?     438
Impacted Files Coverage Δ
components/tooltip/nz-tooltip.module.ts 100% <ø> (ø)
components/popconfirm/nz-popconfirm.component.ts 96.29% <100%> (ø)
components/popover/nz-popover.directive.ts 100% <100%> (ø)
components/tooltip/base/public-api.ts 100% <100%> (ø)
components/popconfirm/nz-popconfirm.directive.ts 100% <100%> (ø)
components/tooltip/nz-tooltip.directive.ts 100% <100%> (ø)
components/popover/nz-popover.component.ts 90% <100%> (ø)
components/tooltip/public-api.ts 100% <100%> (ø)
components/tooltip/nz-tooltip.component.ts 87.5% <83.33%> (ø)
...mponents/tooltip/base/nz-tooltip-base.directive.ts 92.12% <92.12%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb7219...60cd408. Read the comment docs.

@netlify
Copy link

netlify bot commented Aug 2, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 60cd408

https://deploy-preview-3909--ng-zorro-master.netlify.com

@wzhudev wzhudev marked this pull request as ready for review August 2, 2019 11:40
@wzhudev wzhudev requested a review from vthinkxie August 6, 2019 09:57
components/popconfirm/doc/index.en-US.md Outdated Show resolved Hide resolved
components/popconfirm/demo/basic.ts Outdated Show resolved Hide resolved
components/tooltip/doc/index.en-US.md Outdated Show resolved Hide resolved
components/tooltip/doc/index.zh-CN.md Outdated Show resolved Hide resolved
@vthinkxie vthinkxie merged commit c21d948 into NG-ZORRO:master Aug 13, 2019
@wzhudev wzhudev deleted the refactor-tooltip branch August 13, 2019 08:04
wzhudev pushed a commit that referenced this pull request Aug 13, 2019
* fix: empty judgement

* fix: remove useless property

* fix(module:popover): fix propertyName

patch #3909
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* refactor: refactor tooltip components

* chore: move some deprecation warnings to 9.0.0
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* fix: empty judgement

* fix: remove useless property

* fix(module:popover): fix propertyName

patch NG-ZORRO#3909
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* refactor: refactor tooltip components

* chore: move some deprecation warnings to 9.0.0
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix: empty judgement

* fix: remove useless property

* fix(module:popover): fix propertyName

patch NG-ZORRO#3909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename nzTitle based on the directive
3 participants