Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and add translations for de_DE #4239

Merged
merged 2 commits into from
Sep 29, 2019
Merged

Update and add translations for de_DE #4239

merged 2 commits into from
Sep 29, 2019

Conversation

gamsterx
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe: i18n translations added and updated (de_DE)

What is the current behavior?

Console warning "Missing translations for "Text" in language "de".You can use
NzI18nService.setLocale" as a temporary fix. Welcome to submit a pull request to help us optimize the translations!"

Issue Number: N/A

What is the new behavior?

Translations added and updated

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Added missing translations
Propose better translations for Table.selectAll and Table.selectInvert
@netlify
Copy link

netlify bot commented Sep 28, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 87664d9

https://deploy-preview-4239--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Sep 28, 2019

Codecov Report

Merging #4239 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4239      +/-   ##
==========================================
- Coverage   92.31%   92.31%   -0.01%     
==========================================
  Files         519      519              
  Lines       10963    10963              
  Branches     1984     1984              
==========================================
- Hits        10121    10120       -1     
  Misses        419      419              
- Partials      423      424       +1
Impacted Files Coverage Δ
components/time-picker/time-holder.ts 95.61% <0%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704c34f...87664d9. Read the comment docs.

@wzhudev
Copy link
Member

wzhudev commented Sep 29, 2019

Danke! Thank you for submitting a PR.

Please change your commit message to meet our committing guideline. https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit-message-format

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit f819fad into NG-ZORRO:master Sep 29, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants