Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:carousel): throw error when changing rtl #6318

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Jan 6, 2021

close #6301

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 6, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #6318 (dde8096) into master (a2cc9a7) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6318   +/-   ##
=======================================
  Coverage   89.91%   89.92%           
=======================================
  Files         478      478           
  Lines       15251    15250    -1     
  Branches     2318     2318           
=======================================
  Hits        13713    13713           
  Misses        924      924           
+ Partials      614      613    -1     
Impacted Files Coverage Δ
components/carousel/carousel.component.ts 92.61% <ø> (-1.39%) ⬇️
components/time-picker/time-holder.ts 95.78% <0.00%> (+1.05%) ⬆️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2cc9a7...dde8096. Read the comment docs.

@hsuanxyz hsuanxyz merged commit bef7e29 into NG-ZORRO:master Jan 7, 2021
@wzhudev
Copy link
Member

wzhudev commented Jan 8, 2021

Oh. I see why we need a direction property on strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

carousel: throw [Cannot read property 'style' of undefined] when changed direction
3 participants