Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review NoComp reduced complexity mode patch indexing #775

Closed
glemieux opened this issue Sep 15, 2021 · 2 comments
Closed

Review NoComp reduced complexity mode patch indexing #775

glemieux opened this issue Sep 15, 2021 · 2 comments

Comments

@glemieux
Copy link
Contributor

The changes associated with rosiealice#6 for the sp mode PR appear to cause an area summation issue. The instigating issue appears to be the removal of a logic check that only forces sp mode to have start_patch = 0, allowing nocomp mode to have the same start patch as well. More discussion of the issue can be found in the comments of the PR here: rosiealice#6 (comment)
@glemieux glemieux mentioned this issue Dec 10, 2022
Open
@jkshuman
Copy link
Contributor

jkshuman commented Feb 1, 2023

@glemieux Is this still an issue? Or can it be closed with the close of rosiealice#6 (comment) ?

@glemieux
Copy link
Contributor Author

glemieux commented Feb 1, 2023

Good catch. This was likely dealt with in PR #805.

@glemieux glemieux closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glemieux @jkshuman