Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logistic model of root growth #738

Merged
merged 31 commits into from
Oct 13, 2021
Merged

Conversation

JunyanDing
Copy link
Contributor

@JunyanDing JunyanDing commented Apr 8, 2021

Description:

  1. simulates the rooting depth of cohorts using a logistic model. See attached file for detail
    FATESHydroDynamicRoots.pdf
  2. modified the corresponding routines so that the soil layers can have zero roots so that 1) that layer will be bypassed in 1D solver, 2) fine root water content in soil layer deeper than maximum rooting depth will be set to zero so, 3) handle zero (and infinite) situation in calculating rhizosphere shell conductance

issue #726

Fixes: #786

Collaborators:

Ryan Knox, Chonggang Xu, Charlie Koven

Expectation of Answer Changes:

Checklist:

  • [ x] My change requires a change to the documentation.
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

rgknox and others added 2 commits July 21, 2021 11:45
rgknox and others added 11 commits September 27, 2021 11:51
Co-authored-by: Rosie Fisher <rosieafisher@gmail.com>
Co-authored-by: Rosie Fisher <rosieafisher@gmail.com>
Co-authored-by: Rosie Fisher <rosieafisher@gmail.com>
Co-authored-by: Rosie Fisher <rosieafisher@gmail.com>
Co-authored-by: Rosie Fisher <rosieafisher@gmail.com>
Co-authored-by: Rosie Fisher <rosieafisher@gmail.com>
Co-authored-by: Rosie Fisher <rosieafisher@gmail.com>
Co-authored-by: Rosie Fisher <rosieafisher@gmail.com>
Co-authored-by: Rosie Fisher <rosieafisher@gmail.com>
Co-authored-by: Rosie Fisher <rosieafisher@gmail.com>
@rgknox
Copy link
Contributor

rgknox commented Oct 11, 2021

Site level comparison between this branch and master, similar settings, BCI.
rootdepth-v2_plots.pdf
Note, while these results are similar, I do not expect b4b results against base in regression testing. We have made small modifications to error caps.

@rgknox rgknox self-requested a review October 11, 2021 15:23
@rgknox
Copy link
Contributor

rgknox commented Oct 12, 2021

tests pass w/ expected fails: /glade/scratch/rgknox/tests_1010-193620ch

@rgknox rgknox merged commit 5d449e4 into NGEET:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

temp hydro arrays are not thread safe
3 participants