Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value of NAT in config is null #97

Closed
eeldivad opened this issue Feb 29, 2024 · 2 comments
Closed

Default value of NAT in config is null #97

eeldivad opened this issue Feb 29, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request needs testing (on unstable) If the feature exists, but isnt yet released

Comments

@eeldivad
Copy link

It's not a big deal but when we run "sudo ./wag gen-config" it generates the config file with
"NAT": null

When starting up the service I see NAT is enabled: Set routing mode to MASQUERADE (NAT)

Shouldn't the confg generator default "NAT": true instead of null? The null here makes me think that NAT is off. Not a big deal but just wanted to mention it if you could fix it in the next release.

@NHAS NHAS added the enhancement New feature or request label Apr 26, 2024
@NHAS NHAS self-assigned this Apr 26, 2024
@NHAS
Copy link
Owner

NHAS commented Apr 26, 2024

Yep! Thats entirely fair, I've been a bit slow on this project recently due to getting the clustering all working. So changes like this are a bit on the back burner (especially as I plan to remove the cli config generation in favor of a web UI at some point)

@NHAS
Copy link
Owner

NHAS commented Apr 26, 2024

I've just added the json tag to omit empty, it'll default to true internally. Thanks! This is now on unstable.

@NHAS NHAS added the needs testing (on unstable) If the feature exists, but isnt yet released label Apr 26, 2024
@NHAS NHAS closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs testing (on unstable) If the feature exists, but isnt yet released
Projects
None yet
Development

No branches or pull requests

2 participants