Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract slots for classes that only start at mid semester #108

Closed
diogotvf7 opened this issue Mar 19, 2024 · 1 comment
Closed

Extract slots for classes that only start at mid semester #108

diogotvf7 opened this issue Mar 19, 2024 · 1 comment
Assignees

Comments

@diogotvf7
Copy link
Contributor

The problem

The Comunicação Profissional course unit, for example, is only given to a set of classes at each time, three times per semester.
In the current way slots are parsed, we're only checking for the occurrence of that class in the beginning of the semester, we should also check the the other time intervals in order to be able to check for other classes and slots.

@Wallen-Ribeiro Wallen-Ribeiro linked a pull request May 8, 2024 that will close this issue
@tomaspalma
Copy link
Member

As stated in issue #110 , sigarra changed the HTML structure of the schedules page in a manner that now the HTML does not already contain the data to render, rather using javascript to make a request to an API and then populating the contents of the HTML.

Now the API returns all of the classes, whether or not they last all of the semester and so on, which makes this issue deprecated, since it will be solved in the refactor of the scrapper.

@tomaspalma tomaspalma closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants