Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading CSV file from Scopus #25

Closed
stijnh opened this issue Feb 17, 2023 · 6 comments
Closed

Loading CSV file from Scopus #25

stijnh opened this issue Feb 17, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@stijnh
Copy link
Member

stijnh commented Feb 17, 2023

The Scopus web search engine offers the ability to export search results as a CSV file. It might be interesting to add a load_scopus_csv function, similar to load_ieee_csv and load_springer_csv

@stijnh stijnh added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 17, 2023
@stijnh
Copy link
Member Author

stijnh commented Mar 2, 2023

This has been partial resolved by #29. But it would be nice to have a load_scopus_csv function specifically for Scopus CSV files.

@tleedepriest
Copy link
Contributor

I was just working with the exported Scopus CSV and was looking in the code base for this exact functionality. I would be happy to help! It would be my first open-source contribution.

@stijnh
Copy link
Member Author

stijnh commented May 17, 2023

Hi Travis,

If you would like to contribute to litstudy by adding functionality for loading Scopus CSV files, we would be happy to review a pull request!

The steps for this would be roughly the following:

  1. Fork this repository
  2. Add a file litstudy/sources/scopus_csv.py
  3. Add the function load_scopus_csv. You can base your work on ieee.py and springer.py
  4. Add the load_scopus_csv function to litstudy/__init__.py and litstudy/sources/__init__.py
  5. Add a test tests/test_sources_scopus_csv.py. You can base the test on test_sources_ieee.py
  6. Format your code with the black formatting tool
  7. Make a pull request for this repository. We can review your changes

Let me know if you run into any issues. Some more resources about creating pull requests:

If you want to give it a try, shall I assign this issue to you?

@tleedepriest
Copy link
Contributor

Yes, I'd like to give it a go. I was currently working in scopus.py, but I will follow your suggestion and add a new file. Given that suggestion, would there be preference to create a new object ScopusCsvDocument, Instead of modifying the current ScopusDocument object to accommodate loading the csv?

@stijnh
Copy link
Member Author

stijnh commented May 17, 2023

Great!

I don't think it is possible to use ScopusDocument since that class relies as pybliometrics and simply forwards all the method calls to pybliometrics. I feel like it would be difficult to modify this class to support CSV files. But if you find a way then that is also fine. It is probably best to add a new ScopusCsvDocument class

@stijnh
Copy link
Member Author

stijnh commented Jun 8, 2023

This has now been resolved thanks to PR #45 (Thanks for your contribution tleedepriest!)

@stijnh stijnh closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants