Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo consistency 0.12.3 #1022

Merged
merged 7 commits into from
Mar 6, 2023
Merged

Repo consistency 0.12.3 #1022

merged 7 commits into from
Mar 6, 2023

Conversation

timbru
Copy link
Contributor

@timbru timbru commented Mar 3, 2023

No description provided.

@timbru timbru marked this pull request as draft March 3, 2023 14:28
@timbru timbru marked this pull request as ready for review March 6, 2023 10:35
@timbru timbru requested a review from ximon18 March 6, 2023 10:35
ximon18
ximon18 reviewed Mar 6, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
ximon18
ximon18 reviewed Mar 6, 2023
View reviewed changes
src/commons/api/rrdp.rs Outdated Show resolved Hide resolved
ximon18
ximon18 approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@ximon18 ximon18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I recall already reviewing this in the original PR and giving feedback that was incorporated, so I'm not going to review it in depth again.

Tim Bruijnzeels added 2 commits March 6, 2023 15:23
@timbru timbru merged commit e920984 into main Mar 6, 2023
@timbru timbru deleted the repo-consistency-0.12.3 branch March 6, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ximon18 ximon18 ximon18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timbru @ximon18