Remove RepositoryManager RwLock #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 31, 2023 16:23
This should not be needed. And it might lead to write lock starvation. Typically cliens would call list before sending updates and not send two requests at the same time. In case we don't have the read lock then the content may not contain an update for another publisher, but that is irrelevant here.
|
I can understand why the previous deadlock happened, but I am not certain something similar could not still happen with the current locks in the |
Koenvh1
approved these changes
Feb 10, 2023
timbru
pushed a commit
that referenced
this pull request
Feb 21, 2023
timbru
pushed a commit
that referenced
this pull request
Feb 21, 2023
timbru
pushed a commit
that referenced
this pull request
Mar 3, 2023
timbru
pushed a commit
that referenced
this pull request
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[draft] We should make a branch for
prep-0.12.2and merge to that if this is stable.This PR removes the RwLock in RepositoryManager.
We saw issues where a busy Krill Publication Server would freeze without any reported issues. We suspect that this may be due to a deadlock or lock starvation issue in RepositoryManager. A version where read locks were no longer acquired (they are actually not needed) - was deployed and so far seems stable.
Then one more commit was done to remove the RwLock altogether in this layer. It is in fact not needed because there are existing RwLocks in the layers below this (
WalStore::send_command) to ensure that actual updates do happen sequentially.