Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for protobuf-c with pkg-config #999

Merged
merged 1 commit into from Jan 30, 2024

Conversation

NickCao
Copy link
Contributor

@NickCao NickCao commented Jan 26, 2024

This is easier to use than --with-protobuf-c=.

Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks like it is good code. Useful to detect more easily the protobuf-c location.

@wcawijngaards wcawijngaards merged commit 0b74f2a into NLnetLabs:master Jan 30, 2024
1 check passed
wcawijngaards added a commit that referenced this pull request Jan 30, 2024
- Merge #999: Search for protobuf-c with pkg-config.
@wcawijngaards
Copy link
Member

Thanks for the additional check and that may make it easier to use the configure script! The script snippet is merged into the code repository and after a rerun of autoconf part of the configure script.

gthess added a commit that referenced this pull request Feb 7, 2024
jedisct1 added a commit to jedisct1/unbound that referenced this pull request Feb 14, 2024
* nlnet/master:
  - These fixes are part of the 1.19.1 release, that is a security   point release on 1.19.0, the code repository continues with these   fixes, with version number 1.19.2.
  - Fix CVE-2023-50868, NSEC3 closest encloser proof can exhaust CPU.
  - Fix CVE-2023-50387, DNSSEC verification complexity can be exploited to   exhaust CPU resources and stall DNS resolvers.
  - Fix documentation for access-control in the unbound.conf man page.
  - autoconf.
  - For NLnetLabs#1006: fix logic error introduced by previous fix.
  - autoheader, autoconf.
  - Fix NLnetLabs#1006: Can't find protobuf-c package since NLnetLabs#999.
  Autoconf and changelog note for NLnetLabs#999 - Merge NLnetLabs#999: Search for protobuf-c with pkg-config.
  Search for protobuf-c with pkg-config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants