Reset keepalive per new tcp session #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TCY16
approved these changes
Nov 2, 2021
gthess
added a commit
that referenced
this pull request
Dec 1, 2021
- Merge PR #562 from Willem: Reset keepalive per new tcp session.
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jan 13, 2022
* nlnet/master: (36 commits) - Add missing configure flags for optional features in the documentation. - Fix Unbound capitalization in the documentation. - Fix to pick up other class local zone information before unlock. - Allow local-data for classes other than IN to inherit a configured local-zone's type if possible, instead of defaulting to type transparent as per the implicit rule. - Add code similar to fix for ldns for tab between strings, for consistency, the test case was not broken. Continue with version 1.14.1 - Fix validator debug output about DS support, print correct algorithm. Changelog note for NLnetLabs#581 Fix -Wshadow Fix -Wmissing-prototypes by declaring functions static. - Fix compile warning for if_nametoindex on windows 64bit. - Fix doc/unbound.doxygen to remove obsolete tag warning. - configure is set to 1.14.0, and release branch. - Fix NLnetLabs#574: Review fixes for size allocation. - Fix NLnetLabs#454: listen_dnsport.c:825: error: ‘IPV6_TCLASS’ undeclared. Changelog note for NLnetLabs#530: - Merge PR NLnetLabs#530 from Shchelk: Fix: dereferencing a null pointer. Changelog note for NLnetLabs#522: - Merge PR NLnetLabs#522 from sibeream: memory management violations fixed. Changelog note for NLnetLabs#562: - Merge PR NLnetLabs#562 from Willem: Reset keepalive per new tcp session. Changelog note for NLnetLabs#555: - Merge PR NLnetLabs#555 from fobser: Allow interface names as scope-id in IPv6 link-local addresses. Changelog note for NLnetLabs#493: - Merge PR NLnetLabs#493 from Jaap: Fix generation of libunbound.pc. Changelog note for NLnetLabs#511: - Merge PR NLnetLabs#511 from yan12125: Reduce unnecessary linking. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if edns-tcp-keepalive was configured, it was not sent along in responses unless a client on a TCP (or TLS) session signaled support for it, but then the options was sent along in responses to all clients using TCP (or TLS), also to the clients that did not signal support by sending a initial query with the option if they would reuse the internal comm_point for the TCP session.
Although according to RFC7828 Section 3.3.2. a server does not need an initial query with keepalive option to sent along the option in responses, it is peculiar that a random client was needed to sent the option for unbound to start sending along the option on all responses (on TCP sessions that reused that comm_point). Clearly the intention was to sent along the option in responses only to those clients that signaled support by sending an initial query with the option. This PR makes it behave just like that.