Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading JSON config - Trim keys as Json allows spaces in keys #419

Merged
merged 1 commit into from
May 11, 2020

Conversation

snakefoot
Copy link
Contributor

Spaces are automatically ignore in xml:

<target type="file"    fileName="hello.txt" />

But not with json:

"file" {
  "  fileName": "hello.txt"
}

See also: https://stackoverflow.com/a/61549064/193178

@snakefoot snakefoot added this to the 1.6.3 milestone May 1, 2020
@snakefoot snakefoot closed this May 2, 2020
@snakefoot snakefoot reopened this May 2, 2020
@codecov-io
Copy link

codecov-io commented May 2, 2020

Codecov Report

Merging #419 into master will increase coverage by 0.06%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
+ Coverage   82.29%   82.36%   +0.06%     
==========================================
  Files          14       14              
  Lines        1192     1202      +10     
  Branches      195      199       +4     
==========================================
+ Hits          981      990       +9     
  Misses        141      141              
- Partials       70       71       +1     
Impacted Files Coverage Δ
...ensions.Logging/Config/NLogLoggingConfiguration.cs 92.34% <94.73%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bd3bcb...55d4d8c. Read the comment docs.

@304NotModified 304NotModified changed the title NLogLoggingConfiguration - Trim config-keys as Json allows spaces in keys Reading JSON config - Trim keys as Json allows spaces in keys May 11, 2020
@304NotModified 304NotModified merged commit 034f279 into NLog:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants