-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for IHealthCheck for netcoreapp3.1 + net6.0 #658
Comments
is this still desired? I am preparing pull requests for AspNetCore.Diagnostics.HealthChecks for IBM DB2 and MQ so I am somewhat familiar. I can try and build a prototype. |
I think it is still interesting to have diagnostics from the NLog-targets, and maybe also basic-statistics about logged-errors-per-minute-by-host-application. |
There are several locations to place the health check classes One is in NLog.Web.AspNetCore itself, this will require 1 or 2 additional NuGet package dependencies added, for the IHealthCheck and related interfaces. But as these are official Microsoft NuGet packages this may be OK. One is in a separate project named NLog.Web.AspNetCore.HealthChecks. This will have only the 1 or 2 NuGet dependencies, but will also have very few classes (an extension class, and a class to implement the actual check) so not sure it deserves a project. The last one is to host the NLog.Web.AspNetCore.HealthChecks in the https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks repo, where there are many others...but then we will not be master maintainer of the project and cannot makes PR and release ourselves. As the HealthCheck NuGet packages state they support net std 2.0 and net 4.6.1, we 'may' be able to support that as well, but certainly core 3.1/5.0/6.0 they support. |
Good point, yes if we skip netstd 20/4.6.1 then is auto included. then we can leave in the project with no changes. |
Something similar to these:
https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/tree/master/src
Maybe something like this:
The text was updated successfully, but these errors were encountered: