Naming: consistent private fields #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uhh please make a search and replace for |
3 tasks
|
will do in another PR, trying to keep the changes a small as possible. |
prefixed with _ - consistent - easier to review in GitHub - no forgot-this-bugs
304NotModified
force-pushed
the
private-fields-underscore-prefix
branch
2 times, most recently
from
8603a5b
to
ec4a666
Compare
304NotModified
force-pushed
the
private-fields-underscore-prefix
branch
from
ec4a666
to
9dad67a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2327 +/- ##
=======================================
- Coverage 82% 82% -<1%
=======================================
Files 317 317
Lines 22716 22761 +45
Branches 2784 2806 +22
=======================================
+ Hits 18618 18654 +36
+ Misses 3396 3385 -11
- Partials 702 722 +20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prefixed with
_only private fields changed
Currently only the main project, so to be sure not of the tests has been changed.
unneeded
this.will be removed in another PR