Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant qualifiers #2336

Closed
wants to merge 0 commits into from
Closed

Remove redundant qualifiers #2336

wants to merge 0 commits into from

Conversation

c0shea
Copy link
Contributor

@c0shea c0shea commented Oct 10, 2017

Removes this. and other redundant qualifiers.

Not sure why AppVeyor is failing on this test, but it looks like it's failing in master, too.

It's unclear if this is a bug of a feature. Probably this will a config setting in the feature
      System.InvalidOperationException : Error when parsing line '1 52' in file C:\Users\appveyor\AppData\Local\Temp\1\2e905fb6-63fd-4425-ba34-c5738bf75160\Archive\0001_test_2_500_none_mutex_archive.txt
      ---- Assert.Equal() Failure
      Expected: 22
xunit.console.x86.exe :     NLog.UnitTests.Targets.ConcurrentFileTargetTests.SimpleConcurrentTest(numProcesses: 2, numLogs: 500, mode: "none|mutex|archive") [FAIL]
At C:\projects\nlog\run-tests.ps1:33 char:1
+ & ${env:xunit20}\xunit.console.x86.exe .\tests\NLog.UnitTests\bin\rel ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (    NLog.UnitTe...rchive") [FAIL]:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError
 
      Actual:   52

@304NotModified
Copy link
Member

thanks! But this will probable clash with #2327

@304NotModified
Copy link
Member

Are you using Refactor tools for this?

@304NotModified
Copy link
Member

It's unclear if this is a bug of a feature. Probably this will a config setting in the feature
System.InvalidOperationException : Error when parsing line '1 52' in file C:\Users\appveyor\AppData\Local\Temp\1\2e905fb6-63fd-4425-ba34-c5738bf75160\Archive\0001_test_2_500_none_mutex_archive.txt
---- Assert.Equal() Failure
Expected: 22
xunit.console.x86.exe : NLog.UnitTests.Targets.ConcurrentFileTargetTests.SimpleConcurrentTest(numProcesses: 2, numLogs: 500, mode: "none|mutex|archive") [FAIL]

Unstable test :( See #2329

@c0shea
Copy link
Contributor Author

c0shea commented Oct 11, 2017

Yes, I'm using ReSharper and running code analysis on the solution. I can redo it once you merge the other request if that's safer.

Also, what are your thoughts on expression-bodied members and using var?

@304NotModified
Copy link
Member

304NotModified commented Oct 11, 2017

Yes, I'm using ReSharper and running code analysis on the solution. I can redo it once you merge the other request if that's safer.

It has been merged. please redo :) thx!

Also, what are your thoughts on expression-bodied members

Like. New PR would be great!

and using var?

Doubting. I like var and i'm using it for everything (makes refactoring easier), but there are many people against it. What do you think? Maybe only for trivial changes? (e.g. var x = new MyClass)

Yes, I'm using ReSharper

good choice 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants