New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant qualifiers #2342
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2342 +/- ##
=======================================
- Coverage 82% 82% -<1%
=======================================
Files 318 318
Lines 22771 22770 -1
Branches 2782 2782
=======================================
- Hits 18668 18660 -8
- Misses 3401 3409 +8
+ Partials 702 701 -1 |
@304NotModified Not sure why Travis is failing the build with |
Travis is buggy. Will retry (a few times). |
worked after 1 retry :) Double check, you used R# for this isn't? |
Yes, I used ReSharper for this. So nice to do it in s couple clicks for the solution. |
thanks!! |
Must admit I kind of liked the NLog-prefix for the NLog-namespace specifications. But the removal of explicit |
I inadvertently did a force push, which closed #2336 and I couldn't seem to get it back. This PR is a redo now that #2327 has been merged.
To continue on our previous discussion, I'll create a new PR for expression-bodied members once this one is merged to avoid more conflicts.
I personally love to use var for everything. I know some people hate it because they want to see the types explicitly spelled out, but to me that's too verbose. If I want to know the type, I can just hover over the variable ;) That said, I could go either way depending on your thoughts. I think it would make the most sense for complex expressions, e.g. LINQ and other nested generic types, but it would be fine to keep using
string test = "123"
instead of making that a var.