-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variance Partition estimates of Stddev #1037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing then I think it's ready to be approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. See comments.
Not sure what this means. andytangborn dismissed guillaumevernieres’s stale review via 837de5a now |
it means his previous review is no longer applicable because you updated the branch |
I just noticed these lines in chem_diagb.h. These should be removed I think?
|
@andytangborn yes you don't need ssh or sst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andytangborn for this, I'll approve and merge, and we can fix any minor issues later when we incorporate it into the workflow. Great work!
* upstream/develop: More marine DA bufixes (#1069) Add basin flags to the ocean obs (#1067) Revert "Prepare observations for snow DA updates to the ensemble members" (#1066) Fix aero_diagb template (#1064) Refactoring prepocnobs task (#1049) Ensemble diagnostics not triggered properly (#1060) New ocean/ice B diag (#1050) Remove R2D2 and SOLO from the GitHub Actions workflow CI (#1058) Variance Partition estimates of Stddev for aerosols (#1037) Removing ctests of an obsolete bufr_converter in SOCA (#1056)
This PR creates code and a yaml (adapted from SOCA) that computes time dependent background error standard deviations using neighboring grid points. These are created "on the fly", eliminating a need for staticB stddev files that need to be switched in or out each season.