Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basin flags to the ocean obs #1067

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Add basin flags to the ocean obs #1067

merged 5 commits into from
Apr 22, 2024

Conversation

guillaumevernieres
Copy link
Contributor

AndrewEichmann-NOAA
AndrewEichmann-NOAA previously approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Was it crashing before due to the lack of a masking file?

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 22, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 22, 2024
@emcbot
Copy link

emcbot commented Apr 22, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon Apr 22 15:44:46 UTC 2024 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Apr 22 16:34:28 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Mon Apr 22 16:50:20 UTC 2024
Tests: 93% tests passed, 3 tests failed out of 45
	1767 - test_gdasapp_atm_jjob_var_run (Failed)
	1768 - test_gdasapp_atm_jjob_var_inc (Failed)
	1769 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1067/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Apr 22, 2024
@emcbot
Copy link

emcbot commented Apr 22, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Mon Apr 22 10:36:30 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Apr 22 11:29:46 CDT 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Mon Apr 22 11:51:30 CDT 2024
Tests: 93% tests passed, 3 tests failed out of 45
	1768 - test_gdasapp_atm_jjob_var_run (Failed)
	1769 - test_gdasapp_atm_jjob_var_inc (Failed)
	1770 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1067/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Apr 22, 2024
@guillaumevernieres guillaumevernieres merged commit 3bb46b6 into develop Apr 22, 2024
17 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/ocean-basin-on branch April 22, 2024 17:52
@guillaumevernieres guillaumevernieres mentioned this pull request Apr 22, 2024
Merged
guillaumevernieres added a commit that referenced this pull request Apr 23, 2024
@guillaumevernieres
More marine DA bufixes (#1069)
c54bf6d 
- fixes #1068 
- fixes #1067 
- fixes #985
danholdaway added a commit that referenced this pull request Apr 23, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
b0591dd 
* upstream/develop:
  More marine DA bufixes  (#1069)
  Add basin flags to the ocean obs (#1067)
  Revert "Prepare observations for snow DA updates to the ensemble members" (#1066)
  Fix aero_diagb template (#1064)
  Refactoring prepocnobs task (#1049)
  Ensemble diagnostics not triggered properly (#1060)
  New ocean/ice B diag (#1050)
  Remove R2D2 and SOLO from the GitHub Actions workflow CI (#1058)
  Variance Partition estimates of Stddev for aerosols (#1037)
  Removing ctests of an obsolete bufr_converter in SOCA (#1056)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewEichmann-NOAA AndrewEichmann-NOAA AndrewEichmann-NOAA approved these changes

@apchoiCMD apchoiCMD Awaiting requested review from apchoiCMD

Assignees
No one assigned
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ocean basin is missing in the obsprep yamls
3 participants
@guillaumevernieres @emcbot @AndrewEichmann-NOAA