Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing ctests of an obsolete bufr_converter in SOCA #1056

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Removing ctests of an obsolete bufr_converter in SOCA #1056

merged 3 commits into from
Apr 17, 2024

Conversation

apchoiCMD
Copy link
Collaborator

This PR includes,

  • Remove the bufr_converters that are binary executable ones
  • Remove shell script that is related to bufr_converter
  • Remove unused test inputs
  • Resolves Clean the marine obsproc ctest #951

@apchoiCMD apchoiCMD marked this pull request as ready for review April 17, 2024 17:53
@apchoiCMD apchoiCMD marked this pull request as draft April 17, 2024 17:55
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 17, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 17, 2024
@emcbot
Copy link

emcbot commented Apr 17, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Wed Apr 17 13:20:29 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Apr 17 14:15:20 CDT 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Wed Apr 17 14:37:10 CDT 2024
Tests: 91% tests passed, 4 tests failed out of 45
	1768 - test_gdasapp_atm_jjob_var_run (Failed)
	1769 - test_gdasapp_atm_jjob_var_inc (Failed)
	1770 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1056/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Apr 17, 2024
guillaumevernieres
guillaumevernieres approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apchoiCMD

@guillaumevernieres guillaumevernieres marked this pull request as ready for review April 17, 2024 19:47
@emcbot
Copy link

emcbot commented Apr 17, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Apr 17 18:29:00 UTC 2024 on hfe03
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Apr 17 19:16:44 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Wed Apr 17 19:53:22 UTC 2024
Tests: 91% tests passed, 4 tests failed out of 45
	1767 - test_gdasapp_atm_jjob_var_run (Failed)
	1768 - test_gdasapp_atm_jjob_var_inc (Failed)
	1769 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1056/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Apr 17, 2024
@guillaumevernieres guillaumevernieres merged commit 19dd7e8 into develop Apr 17, 2024
16 of 17 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/remove_bufr_ctest branch April 17, 2024 20:00
danholdaway added a commit that referenced this pull request Apr 23, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
b0591dd 
* upstream/develop:
  More marine DA bufixes  (#1069)
  Add basin flags to the ocean obs (#1067)
  Revert "Prepare observations for snow DA updates to the ensemble members" (#1066)
  Fix aero_diagb template (#1064)
  Refactoring prepocnobs task (#1049)
  Ensemble diagnostics not triggered properly (#1060)
  New ocean/ice B diag (#1050)
  Remove R2D2 and SOLO from the GitHub Actions workflow CI (#1058)
  Variance Partition estimates of Stddev for aerosols (#1037)
  Removing ctests of an obsolete bufr_converter in SOCA (#1056)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA

Assignees
No one assigned
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean the marine obsproc ctest
3 participants
@apchoiCMD @emcbot @guillaumevernieres