-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ensemble based bump localization to gsibec hybvar yaml #461
add ensemble based bump localization to gsibec hybvar yaml #461
Conversation
Install Hera:
The
I previously ran the ctests in my working copy.
@jiaruidong2017 , I recommend that you modify Orion:
PR #457 addresses the soca failures on both Hera and Orion. |
@RussTreadon-NOAA whoops, no I'm just dumb and deleted that directory in R2D2 in an attempt to save space forgetting we still used R2D2 files in these tests... let me restore it from Orion today. |
Got it. Thanks, @CoryMartin-NOAA . I'll rerun when the Hera files are restored. |
Thanks @RussTreadon-NOAA This has been addressed on the PR #463 |
ctests rerun on Hera with the change from PR #463. Orion appears to be having fileset issues this morning. This complicates efforts to refresh Hera |
Automated Global-Workflow GDASApp Testing Results:
|
Automated Global-Workflow GDASApp Testing Results:
|
@RussTreadon-NOAA files should be copied over to Hera now (at least Globus said it has succeeded) |
The copy worked! The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @RussTreadon-NOAA . Soca is still on ignore mode, so do feel free to merge.
Given approval from @guillaumevernieres and @CoryMartin-NOAA , merge this PR into |
This PR is opened to add bump generated localization to
hybvar_gsibec.yaml
. A user provided ensemble is processed by bump to generate localization values.Please note the localization added to the ensemble section of
hybvar_gsibec.yaml
is for demonstration purposes only. Subsequent testing and tuning is required for scientific validation.Fixes #460