Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSI license #476

Closed
climbfuji opened this issue Sep 14, 2022 · 20 comments · Fixed by #745
Closed

GSI license #476

climbfuji opened this issue Sep 14, 2022 · 20 comments · Fixed by #745
Assignees

Comments

@climbfuji
Copy link

This project doesn't seem to have a license, can you add the correct one please?

@RussTreadon-NOAA
Copy link
Contributor

The GSI Handling Review team is going through open GSI issues. May this issue be closed?

@climbfuji
Copy link
Author

@RussTreadon-NOAA Does GSI have a license nowadays?

@RussTreadon-NOAA
Copy link
Contributor

No, I am not aware of the GSI having a license. I am not aware of any plans for the GSI to obtain or add a license.

@climbfuji
Copy link
Author

My recommendation would be to fix that. Here is the legal statement (from https://www.synopsys.com/blogs/software-security/unlicensed-open-source-scenarios.html#:~:text=This%20means%20that%20no%20one,permission%20to%20use%20the%20software.):

A license is a grant of rights. To use a piece of software, whether it’s open source or commercial, you need some grant of rights. In the U.S. and many other places, creative work (including software) is protected by exclusive copyright by default. This means that no one can legally use, copy, distribute, or modify that software without explicit permission from the creator/author. This permission comes in the form of a license that grants the right to do so. Without that license, the baseline assumption is that you do not have permission to use the software.

@RussTreadon-NOAA
Copy link
Contributor

Thank you @climbfuji . Since we no longer have a GSI code manager, let me refer this to others in EMC for their consideration. To help me explain this request to other staff, why does GSI need a license? It's been around for years and is widely used by many. What impact does adding a license have on current users? What impact will it have on future users? Is there a standard template license used by codes accessible from NOAA-EMC?

@climbfuji
Copy link
Author

climbfuji commented Dec 7, 2023

I believe (but not 100% sure, not a legal expert) that the Federal Government / DOC / NOAA require any software that is developed to have an open source license that satisfies certain requirements. There's a lot of complicated legal language out there, check https://resources.data.gov/open-licenses. Most EMC software projects have a GNU Lesser General Public License 3.0 (LGPL) license, so I would go with that one unless that is not possible for GSI.

For spack-stack, for example, we had to go for a Creative Commons Zero license, since JCSDA cannot do LGPL3 (we can only do Creative Commons Zero and Apache2), but the Federal Government cannot do Apache2. It's complicated ...

@climbfuji
Copy link
Author

But independent of all of that, having a software license is considered best practice because it gives users and developers clear guidelines on what they are supposed/allowed to do and what not.

@RussTreadon-NOAA
Copy link
Contributor

Thank you @climbfuji for patiently explaining this to me. I reached out to EMC staff to see how to move forward in a manner consistent with EMC practice.

@RussTreadon-NOAA
Copy link
Contributor

@ShunLiu-NOAA , @CoryMartin-NOAA , and @hu5970 : what's the path forward with this issue?

@CoryMartin-NOAA
Copy link
Contributor

@RussTreadon-NOAA I think we need to ask EMC management to confirm what software license we can/should use

@RussTreadon-NOAA
Copy link
Contributor

I'll reinitiate this conversation with EMC management.

@hu5970
Copy link
Collaborator

hu5970 commented May 7, 2024

We used to have community version of GSI, which is under "GPL-3.0 license".

https://github.com/comgsi/GSI.git

@RussTreadon-NOAA
Copy link
Contributor

This is good to know. Thank you @hu5970 for sharing this information. I'll relay this to EMC management.

@climbfuji
Copy link
Author

I would be very careful with GPLv3. It's not compatible with software using Apache (such as JEDI etc). Apache projects cannot link to/use GPLv3 software. Look at fv3atm - this is LGPL (no version specified), which works for the federal government and can be used by Apache 2 projects.

https://github.com/NOAA-EMC/fv3atm/blob/develop/LICENSE.md

@RussTreadon-NOAA
Copy link
Contributor

Thank you @climbfuji for your input.

@RussTreadon-NOAA
Copy link
Contributor

NOAA-EMC g-w, ufs_utils, wxflow, & NCEPLIBS use GNU Lesser General Public License v3.0. Is this license compatible with Apache?

@climbfuji
Copy link
Author

As far as NOAA or JEDI-folks are concerned, yes. License compatibility is a one-way street. Apache 2 projects like JEDI can link to "lgpl 2.1 or later" software, but not the other way round.

@RussTreadon-NOAA
Copy link
Contributor

Work for this issue will be done in RussTreadon-NOAA:feature/license

RussTreadon-NOAA added a commit to RussTreadon-NOAA/GSI that referenced this issue May 8, 2024
@RussTreadon-NOAA
Copy link
Contributor

Copy global-workflow LICENSE.md to feature/license. Done at e609cbe

@RussTreadon-NOAA RussTreadon-NOAA mentioned this issue May 8, 2024
3 tasks
@RussTreadon-NOAA RussTreadon-NOAA self-assigned this May 8, 2024
@RussTreadon-NOAA
Copy link
Contributor

@climbfuji , I followed the lead of global-workflow and copied their LICENSE.md into feature/license.

GSI PR #745 has been opened to merge the license into develop. I added you to PR #745 as a reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants