-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ww3 diffraction #1144
Draft
aronroland
wants to merge
221
commits into
NOAA-EMC:develop
Choose a base branch
from
erdc:ww3_diffraction
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Ww3 diffraction #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: model/src/w3profsmd_pdlib.F90
…generate boundary conditions ...
… diffraction scheme
…emes for diffraction
…d non-linera shoaling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
wave diffraction following (DOI:10.1016/S0378-3839(03)00065-6).
Description
This enhancement implements wave diffraction based on the MSE within the WW3 model on unstructured grids. WA Gradients are evaluated using linear shape function. Introduces non-linear propagation based on amplitude dispersion, since all advection velocities become function of the solution itself (total fun). This changes basically the whole nature of the scheme in terms of math and numerics. Certain experiences will be necessary and it is an active development. We will add also DOI:10.1016/j.coastaleng.2011.01.002; rudimentary also already included). The latter work improves the solution in the presence of strong shearing currents. The introduced data structures provide also the basis to include non-linear dispersion as suggested by Marten Dingemans and furthermore the redefinition of the conserved quantity based on the work of Staissnie et al. and Toledo et al.. It must be here remarked that wave action is not a conservative variable in the presence in non-homogenous media. See also Willebrand (JCP). However, the most remarkable work is given by Staissnie. This all touches the same issue.
Please also include the following information:
Have fun!
enhancement
No!
-->
Issue(s) addressed
It provides the needed data structures for #937 and introduces the needed work for #931
Commit Message
wave diffraction on unstructured grids.
Check list
Yes
Pending, will be decided by our team.
Testing
Different cases.
See above.
Will be done by ERDC
None
Pending.