-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NCEP regtests for Orion: Rocky9 OS #1263
Update NCEP regtests for Orion: Rocky9 OS #1263
Conversation
Ready for review now, @JessicaMeixner-NOAA |
@MatthewMasarik-NOAA thanks - I think you correctly pointed out some really strange behavior for tp2.1. Let's open an issue for that. I'll run the regtests one more time and then we can merge this in but I think it's likely good to have the tp2.1 differences well documented because I don't think what's happening now is correct. |
Issue #1267 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I obtained the same results as @MatthewMasarik-NOAA
Issue #1267 is a concern that should be further investigated particularly as the answers on orion are different than what was previously gotten on orion and what we get on hera. However, this will enable us to otherwise use orion, so we can merge.
* origin/develop: Enable doxygen documentation in the cmake build system (NOAA-EMC#1281) Simplify MPI ifdefs in subroutine W3MPIO (NOAA-EMC#1266) Add depth scaling value to SMC regression tests. (NOAA-EMC#1264) Updates to NCEP regtests for Orion Rocky9 OS(NOAA-EMC#1263) Fix code stability issue in ww3_outp (NOAA-EMC#1258) Fix GNU regtest CI failure (NOAA-EMC#1253)
* origin/develop: Enable doxygen documentation in the cmake build system (NOAA-EMC#1281) Simplify MPI ifdefs in subroutine W3MPIO (NOAA-EMC#1266) Add depth scaling value to SMC regression tests. (NOAA-EMC#1264) Updates to NCEP regtests for Orion Rocky9 OS(NOAA-EMC#1263) Fix code stability issue in ww3_outp (NOAA-EMC#1258) Fix GNU regtest CI failure (NOAA-EMC#1253)
* feature/gpu/w3srce_refactor: Enable doxygen documentation in the cmake build system (NOAA-EMC#1281) Simplify MPI ifdefs in subroutine W3MPIO (NOAA-EMC#1266) Add depth scaling value to SMC regression tests. (NOAA-EMC#1264) Updates to NCEP regtests for Orion Rocky9 OS(NOAA-EMC#1263) Fix code stability issue in ww3_outp (NOAA-EMC#1258) Fix GNU regtest CI failure (NOAA-EMC#1253) Add option to use NetCDF output instead of binary for point output (NOAA-EMC#1230)
Pull Request Summary
Makes the necessary updates to the NCEP regtests for Orion to account for OS upgrade to Rocky9. This also includes a related bug fix.
Description
Contains the following:
batchq
inmatrix_cmake_ncep
.Please also include the following information:
Issue(s) addressed
Commit Message
Updates to NCEP regtests for Orion Rocky9 OS
Check list
Testing
ww3_tp2.1
- netcdf output. An issue will be created to track these differences.ww3_ufs1.1/unstr
- only due to added switch,BIN2NC
, in netcdf output.develop vs. PR branch
PR vs. PR