Update syntax in config.efcs

NOAA-EMC · Feb 3, 2024 · ff1f787 · ff1f787
1 parent 9febad9
commit ff1f787
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 12 deletions.
diff --git a/jobs/JGLOBAL_FORECAST b/jobs/JGLOBAL_FORECAST
@@ -62,6 +62,8 @@ ${FORECASTSH:-${SCRgfs}/exglobal_forecast.sh}
 status=$?
 [[ ${status} -ne 0 ]] && exit "${status}"
 
+# Send DBN alerts for EnKF
+# TODO: Should these be in post manager instead?
 if [[ "${RUN}" =~ "enkf" ]] && [[ "${SENDDBN}" = YES ]]; then
   for (( fhr = FHOUT; fhr <= FHMAX; fhr + FHOUT )); do
     if (( fhr % 3 == 0 )); then

diff --git a/parm/config/gefs/config.efcs b/parm/config/gefs/config.efcs
@@ -11,7 +11,7 @@ echo "BEGIN: config.efcs"
 # export DO_ICE="NO"
 # export DO_WAVE="NO"
 
-export CASE=${CASE_ENS}
+export CASE="${CASE_ENS}"
 
 # Source model specific information that is resolution dependent
 string="--fv3 ${CASE}"
@@ -28,14 +28,14 @@ source "${EXPDIR}/config.resources" efcs
 
 # nggps_diag_nml
 export FHOUT=${FHOUT_ENKF:-3}
-if [[ ${RUN} == "enkfgfs" ]]; then
-    export FHOUT=${FHOUT_ENKF_GFS:-${FHOUT_ENKF:${FHOUT:-3}}}
+if [[ "${RUN}" == "enkfgfs" ]]; then
+    export FHOUT=${FHOUT_ENKF_GFS:-${FHOUT}}
 fi
 
 # model_configure
 export FHMAX=${FHMAX_ENKF:-9}
-if [[ ${RUN} == "enkfgfs" ]]; then
-   export FHMAX=${FHMAX_ENKF_GFS:-${FHMAX_ENKF:-${FHMAX}}}
+if [[ "${RUN}" == "enkfgfs" ]]; then
+   export FHMAX=${FHMAX_ENKF_GFS:-${FHMAX}}
 fi
 
 # Use serial I/O for ensemble (lustre?)
@@ -61,6 +61,6 @@ export SPPT_LSCALE=500000.
 export SPPT_LOGIT=".true."
 export SPPT_SFCLIMIT=".true."
 
-export restart_interval=${restart_interval_gfs}
+export restart_interval="${restart_interval_gfs}"
 
 echo "END: config.efcs"
diff --git a/parm/config/gfs/config.efcs b/parm/config/gfs/config.efcs
@@ -11,7 +11,7 @@ echo "BEGIN: config.efcs"
 # export DO_ICE="NO"
 export DO_WAVE="NO"
 
-export CASE=${CASE_ENS}
+export CASE="${CASE_ENS}"
 
 # Source model specific information that is resolution dependent
 string="--fv3 ${CASE}"
@@ -30,14 +30,14 @@ source "${EXPDIR}/config.ufs" ${string}
 # nggps_diag_nml
 export FHOUT=${FHOUT_ENKF:-3}
 if [[ ${RUN} == "enkfgfs" ]]; then
-    export FHOUT=${FHOUT_ENKF_GFS:-${FHOUT_ENKF:${FHOUT:-3}}}
+    export FHOUT=${FHOUT_ENKF_GFS:-${FHOUT}}
 fi
 
 # model_configure
 export FHMIN=${FHMIN_ENKF:-3}
 export FHMAX=${FHMAX_ENKF:-9}
 if [[ ${RUN} == "enkfgfs" ]]; then
-   export FHMAX=${FHMAX_ENKF_GFS:-${FHMAX_ENKF:-${FHMAX}}}
+   export FHMAX=${FHMAX_ENKF_GFS:-${FHMAX}}
 fi
 
 # Use serial I/O for ensemble (lustre?)
@@ -66,7 +66,7 @@ export SPPT_LSCALE=500000.
 export SPPT_LOGIT=".true."
 export SPPT_SFCLIMIT=".true."
 
-if [[ "${QUILTING}" = ".true." ]] && [[ "${OUTPUT_GRID}" = "gaussian_grid" ]]; then
+if [[ "${QUILTING}" == ".true." ]] && [[ "${OUTPUT_GRID}" == "gaussian_grid" ]]; then
     export DIAG_TABLE="${HOMEgfs}/parm/ufs/fv3/diag_table_da"
 else
     export DIAG_TABLE="${HOMEgfs}/parm/ufs/fv3/diag_table_da_orig"
@@ -87,12 +87,12 @@ export shal_cnv=".true."
 export FHZER=6
 
 # Set PREFIX_ATMINC to r when recentering on
-if [[ ${RECENTER_ENKF:-"YES"} = "YES" ]]; then
+if [[ ${RECENTER_ENKF:-"YES"} == "YES" ]]; then
    export PREFIX_ATMINC="r"
 fi
 
 # For IAU, write restarts at beginning of window also
-if [[ "${DOIAU_ENKF:-}" = "YES" ]]; then
+if [[ "${DOIAU_ENKF:-}" == "YES" ]]; then
   export restart_interval="3"
 else
   export restart_interval="6"