Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NCO Bug] Improve error message for missing ice input #1253

Closed
KateFriedman-NOAA opened this issue Jan 18, 2023 · 1 comment · Fixed by #2468
Closed

[NCO Bug] Improve error message for missing ice input #1253

KateFriedman-NOAA opened this issue Jan 18, 2023 · 1 comment · Fixed by #2468
Assignees
@KateFriedman-NOAA
Labels
nco-bug Something isn't working in Ops.

Comments

@KateFriedman-NOAA
Copy link
Member

Bugzilla #1374

Details from bugzilla:

In gfs_forecast, if there is missing gfswave.glix_10m.t$CCz.ice com data from gfs_wave_prep, the job fails 
and output displays:

ERROR: WW3ICEINP = YES, but missing ice file
Abort!

Please improve to include the full name of the missing file and to print "FATAL ERROR:" instead of just "ERROR:"
@KateFriedman-NOAA KateFriedman-NOAA added the nco-bug Something isn't working in Ops. label Jan 18, 2023
@KateFriedman-NOAA KateFriedman-NOAA added this to the GFSv17 milestone Jan 18, 2023
@WalterKolczynski-NOAA WalterKolczynski-NOAA removed this from the GFSv17 milestone Jun 21, 2023
@KateFriedman-NOAA
Copy link
Member Author

Line in question in the updated system (found now in forecast_postdet.sh):

https://github.com/NOAA-EMC/global-workflow/blob/develop/ush/forecast_postdet.sh#L594

@KateFriedman-NOAA KateFriedman-NOAA self-assigned this Mar 21, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Apr 8, 2024
@KateFriedman-NOAA
Improve ERROR messages in forecast_postdet.sh
b5152ad 
Resolve bugzilla 1374.

Refs NOAA-EMC#1253
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Apr 8, 2024
@KateFriedman-NOAA
Correct missing L from prior edits
188dda6 
Refs NOAA-EMC#1253
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Apr 8, 2024
@KateFriedman-NOAA
Additional fatal error improvement
3e17ddf 
Refs NOAA-EMC#1253
@KateFriedman-NOAA KateFriedman-NOAA mentioned this issue Apr 8, 2024
Merged
7 tasks
KateFriedman-NOAA added a commit that referenced this issue Apr 10, 2024
@KateFriedman-NOAA
Improve error messaging to resolve bugzilla (#2468)
6d40dbf 
The error messaging for fatal errors in ush/forecast_postdet.sh is 
improved to add "FATAL" where missing and state the file that is 
missing (when not already mentioned). Correction of the error 
message mentioned in the bugzilla is included in this.

Bugzilla 1374 is resolved with this commit.

Resolves #1253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KateFriedman-NOAA KateFriedman-NOAA

Labels
nco-bug Something isn't working in Ops.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve error messaging to resolve bugzilla KateFriedman-NOAA/global-workflow
2 participants
@WalterKolczynski-NOAA @KateFriedman-NOAA