Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messaging to resolve bugzilla #2468

Merged

Conversation

KateFriedman-NOAA
Copy link
Member

Description

This PR takes care of bugzilla #1374. The error messaging for fatal errors is improved to add "FATAL" where missing and state the file that is missing (when not already mentioned). Correction of the error message mentioned in the bugzilla is included in this.

Resolves #1253

Type of change

  • Bugzilla

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Visual inspection

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@aerorahul aerorahul added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Apr 8, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Apr 8, 2024
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@aerorahul
Copy link
Contributor

@KateFriedman-NOAA
The CI is stalled because of issues in #2467

@emcbot emcbot removed the CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress label Apr 9, 2024
@KateFriedman-NOAA
Copy link
Member Author

Have removed the last commit which merged another branch in. Will now complete this PR without that branch merged in.

@KateFriedman-NOAA KateFriedman-NOAA merged commit 6d40dbf into NOAA-EMC:develop Apr 10, 2024
4 checks passed
@KateFriedman-NOAA KateFriedman-NOAA deleted the feature/bugzilla_1374 branch April 10, 2024 14:56
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Apr 15, 2024
* upstream/develop:
  Update fbwind for COM refactor (NOAA-EMC#2479)
  Update parm files for atm product (NOAA-EMC#2486)
  Fix paths in prepocnobs task (NOAA-EMC#2459)
  Add oceanalecn to workflow generator (NOAA-EMC#2409)
  Add support for CADS IR cloud detection scheme in the GSI (NOAA-EMC#2478)
  Improve error messaging to resolve bugzilla (NOAA-EMC#2468)
  Check the DO_JEDISNOWDA condition before adding snow DA analysis to the list (NOAA-EMC#2471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NCO Bug] Improve error message for missing ice input
4 participants