Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one-step cold start implementation. #163

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

JianKuang-Intelsat
Copy link
Contributor

This run style can be turned on using option in "settings" called "onestep"
True if you want on-step cold start;
False if traditional two-step;

This run style can be turned on using option in "settings" called "onestep"
	True if you want on-step cold start;
	False if traditional two-step;
@jiandewang
Copy link
Contributor

works on orion, will test on HERA

@JessicaMeixner-NOAA
Copy link
Contributor

My tests with waves worked on orion for both 1step and 2step and without waves 1 step also worked. If @jiandewang Hera test worked I say this is good to go. Thanks @JianKuang-NOAA and sorry for the delay in testing.

@jiandewang
Copy link
Contributor

works fine on HERA, too

@JianKuang-Intelsat
Copy link
Contributor Author

@JessicaMeixner-NOAA Please approve this PR.

Copy link
Contributor

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JianKuang-NOAA

@JianKuang-Intelsat JianKuang-Intelsat merged commit a6e9ffb into feature/coupled-crow Oct 22, 2020
@JianKuang-Intelsat JianKuang-Intelsat deleted the feature/onestep branch October 22, 2020 20:08
pjpegion added a commit to pjpegion/global-workflow that referenced this pull request Oct 29, 2020
lgannoaa pushed a commit to lgannoaa/global-workflow that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants