Update fbwind for COM refactor #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerorahul
reviewed
Apr 12, 2024
| source prep_step | ||
|
|
||
| for fhr3 in 006 012 024; do | ||
| cp "${COMIN_ATMOS_GRIB_0p25}/gfs.${cycle}.pgrb2.0p25.f${fhr3}" "tmp_pgrb2_0p25${fhr3}" |
There was a problem hiding this comment.
Just making a note that these filenames will be updated in the near future to adhere to EE2 conventions.
aerorahul
reviewed
Apr 12, 2024
scripts/exgfs_atmos_fbwind.sh
Outdated
| # make_ntc_bull.pl WMOBH NONE KWNO NONE tran.fbwnd_pacific ${COMOUTwmo}/tran.fbwnd_pacific.$job_name | ||
| ${USHgfs}/make_ntc_bull.pl WMOBH NONE KWNO NONE tran.fbwnd_pacific ${COMOUTwmo}/tran.fbwnd_pacific.$job_name | ||
| if [[ "${SENDDBN}" == 'YES' ]]; then | ||
| # Should this really be in a SENDDBN block? |
There was a problem hiding this comment.
Not sure. Is make_ntc_bull.pl calling dbnalert? If so, it might be ok.
There was a problem hiding this comment.
It does, though presumably we still want to run it up until the alert point even when DBN is off.
aerorahul
reviewed
Apr 12, 2024
Comment on lines
+21
to
+22
| GRID="0p25" YMD=${PDY} HH=${cyc} declare_from_tmpl -rx COMIN_ATMOS_GRIB_0p25:COM_ATMOS_GRIB_GRID_TMPL | ||
| YMD=${PDY} HH=${cyc} declare_from_tmpl -rx COMOUT:COM_ATMOS_WMO_TMPL |
There was a problem hiding this comment.
Using COMIN and COMOUT to clearly identify input and output directories. Thanks!
aerorahul
approved these changes
Apr 12, 2024
|
Where can I find the test run with AWIPS on WCOSS2? Thanks! |
|
|
The file format of tran.fbwnd_pacific.fbwind under |
|
@GwenChen-NOAA |
scripts/exgfs_atmos_fbwind.sh
Outdated
|
|
||
| ###################### | ||
| # Set up Here Files. | ||
| ###################### | ||
|
|
||
| job_name=$(echo $job|sed 's/[jpt]gfs/gfs/') | ||
| job_name="${job/[jpt]gfs/gfs}" |
There was a problem hiding this comment.
This changes the output filename from tran.fbwnd_pacific.gfs_atmos_fbwind_CC to tran.fbwnd_pacific.fbwind, missing the cycle information. Is it intentionally?
There was a problem hiding this comment.
It shouldn't. This line should function identically to what was here before.
There was a problem hiding this comment.
The output filename on Line 71 is tran.fbwnd_pacific.${job_name}. Did $job change?
There was a problem hiding this comment.
Not exactly. When it is run in ops, $job comes from the scheduler jobname. I don't know what that is. In development, we set it in the rocoto pre-job stub (jobs/rocoto/fbwind.sh). This is the only job I know of that includes the job name in a filename (which seems to me to be a poor practice for this very reason). Presumably, if this were run in ops, the filename would still have the cycle in it.
There was a problem hiding this comment.
I'll change this so it no longer relies on $job for the filename.
There was a problem hiding this comment.
${job_name} is only used to define output filename hereafter. If it's not used elsewhere, we can simply define:
job_name=${model}_${COMPONENT}_${cyc}
or something similar to meet EE2 standard.
There was a problem hiding this comment.
Trying to come up with a new name. Do you know what "tran" means in the current filename?
There was a problem hiding this comment.
Would ${RUN}.atmos.t${cyc}z.wind_profile.pacific.ascii be correct?
CC @aerorahul
There was a problem hiding this comment.
Actually, I'm just going to make it ${RUN}.atmos.t${cyc}z.fbwind.pacific.ascii, at least for now. No need to worry about it if it winds up getting ditched anyway.
@aerorahul, I will try. |
|
fbwind from ops: fbwind from develop Not sure what is going on. I don't think it is anything I did, but maybe. |
WalterKolczynski-NOAA
added a commit
to WalterKolczynski-NOAA/gfs-utils
that referenced
this pull request
Apr 12, 2024
The use of SENDCOM was retired in global workflow. make_ntc_bull is updated to match, and also the indentation is made uniform. Refs NOAA-EMC/global-workflow#2479
7 tasks
|
Traced the issue to:
I've opened a PR to gfs-utils to make the necessary changes to |
WalterKolczynski-NOAA
added
the
blocked
WalterKolczynski-NOAA
added a commit
to WalterKolczynski-NOAA/gfs-utils
that referenced
this pull request
Apr 12, 2024
The use of SENDCOM was retired in global workflow. make_ntc_bull is updated to match. Refs NOAA-EMC/global-workflow#2479
WalterKolczynski-NOAA
added a commit
to NOAA-EMC/gfs-utils
that referenced
this pull request
Apr 12, 2024
# Description The use of SENDCOM was retired in global workflow. make_ntc_bull is updated to match. Refs NOAA-EMC/global-workflow#2479
WalterKolczynski-NOAA
removed
the
blocked
|
The fbwind file is now formatted properly after the update to |
Updates fbwind job for the COM refactor and some other cleanup. fbwind IS STILL NON-FUNCTIONAL after this commit. The exectuable is failing to read the grib1 index file. The grib1 data file looks fine, so this appears to me a problem either with the GRBINDEX executable or with GETGB. Refs: NOAA-EMC#289 Refs: NOAA-EMC#2160
WalterKolczynski-NOAA
force-pushed
the
feature/fbwind
branch
from
c8b84f9
to
1490110
Compare
|
The new gfs.atmos.t00z.fbwind.pacific.ascii file looks good. |
GwenChen-NOAA
approved these changes
Apr 15, 2024
danholdaway
added a commit
to danholdaway/global-workflow
that referenced
this pull request
Apr 15, 2024
* upstream/develop: Update fbwind for COM refactor (NOAA-EMC#2479) Update parm files for atm product (NOAA-EMC#2486) Fix paths in prepocnobs task (NOAA-EMC#2459) Add oceanalecn to workflow generator (NOAA-EMC#2409) Add support for CADS IR cloud detection scheme in the GSI (NOAA-EMC#2478) Improve error messaging to resolve bugzilla (NOAA-EMC#2468) Check the DO_JEDISNOWDA condition before adding snow DA analysis to the list (NOAA-EMC#2471)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates fbwind job for the COM refactor and some other cleanup.
This works on WCOSS but not on Orion. There seems to be a problem with either
grbindexorGETGB()on Orion that causes the executable to be unable to read the grib1 index file. The grib1 data file produced there seems fine. Haven't checked Hera yet, maybe there is a problem with the spack-stack build ofgrbindex.Resolves: #2160
Refs: #289
Type of change
Change characteristics
How has this been tested?
Checklist