Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring ecflow script changes from production that are not in release/gfs.v16.3.0. #975

Closed

Conversation

lgannoaa
Copy link
Contributor

It bring ecflow script changes from production that are not in release/gfs.v16.3.0.

It bring ecflow script changes from production that are not in release/gfs.v16.3.0.
@aerorahul
Copy link
Contributor

@WeiWei-NCO
As we prepare for code handoff, we would like to bring these uncommitted changes (I assume were made by the NCO team) from current production into the release branch that is in preparation for GFS v16.3.0.
A review from you to validate these changes made by NCO would be greatly appreciated.
Also tagging @StevenEarle-NCO for any additional guidance.

@aerorahul
Copy link
Contributor

Just a quick note before I forget.
The resource updates in the .ecf should be consistent w/ config.resources. In this case config.resources.nco.static and may be config.resources.emc.dyn.
If they are not brought in, there won't be a catastrophic failure, however, we will deviate as most of the resource updates are in memory allocation within the ecf
However, there are a couple of wafs ecf jobs in this PR that is altering the task count. That will have an impact. WAFS jobs do not source config files to obtain their resource allocation. They do their own thing and likely these are hard-wired in the exscripts.
The development team should ensure they are consistent in v16.3.0 release branch.

@lgannoaa lgannoaa closed this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants