Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfsv16.3 ecflow merge from parallel #976

Merged

Conversation

lgannoaa
Copy link
Contributor

@lgannoaa lgannoaa commented Aug 16, 2022

New ecflow definition file
ecflow job script with memory requirement change from implementation parallel
Remove ecflow workflow manager package

NOTE:
This PR should be merged after #975

New ecflow definition file
ecflow job script with memory requirement change from implementation parallel
Remove ecflow workflow manager package
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

ecf/scripts/enkfgdas/analysis/create/jenkfgdas_diag.ecf Outdated Show resolved Hide resolved
ecf/scripts/enkfgdas/analysis/create/jenkfgdas_diag.ecf Outdated Show resolved Hide resolved
ecf/scripts/gfs/wave/prep/jgfs_wave_prep.ecf Show resolved Hide resolved
ecf/versions/gfs.ver Show resolved Hide resolved
ecf/versions/obsproc.ver Show resolved Hide resolved
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
@KateFriedman-NOAA Please take a note of the increase in the memory requests in the .ecf and update the config.resources.* accordingly.

ecf/versions/gfs.ver Show resolved Hide resolved
ecf/versions/obsproc.ver Show resolved Hide resolved
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks @lgannoaa !

@KateFriedman-NOAA KateFriedman-NOAA merged commit 86df5d5 into NOAA-EMC:release/gfs.v16.3.0 Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants