Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update atmosphere-lgetkf satwnd yamls #13

Merged
merged 4 commits into from
May 24, 2024
Merged

Update atmosphere-lgetkf satwnd yamls #13

merged 4 commits into from
May 24, 2024

Conversation

RussTreadon-NOAA
Copy link
Contributor

PR #7 updated satwnd yamls in observations/atmosphere. This PR makes the same changes for satwnd yamls in observations/atmosphere-lgetkf.

Resolves #12

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this May 24, 2024
@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request May 24, 2024
Merged
@RussTreadon-NOAA
Copy link
Contributor Author

This PR will be marked Ready for review after the changes in this PR along with GDASApp PR #1128 are tested and confirmed to work.

@RussTreadon-NOAA
Copy link
Contributor Author

bugfix/satwnd_lgetkf has been tested inside the g-w via GDASApp bugfix/satwnd_jcb-gdas. Both GDASApp tests and C96C48_ufs_hybatmDA CI pass. Given this, mark this PR as Ready for review

@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review May 24, 2024 16:26
@RussTreadon-NOAA
Copy link
Contributor Author

FYI: So as to mark GDASApp PR #1128 as Ready for review, I'll merge this PR into develop no later than 2 pm EDT today.

BrettHoover-NOAA
BrettHoover-NOAA approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@BrettHoover-NOAA BrettHoover-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @BrettHoover-NOAA !

@RussTreadon-NOAA RussTreadon-NOAA merged commit 77f9e12 into develop May 24, 2024
1 check passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the bugfix/satwnd_lgetkf branch May 24, 2024 17:47
danholdaway added a commit that referenced this pull request May 28, 2024
@danholdaway
Merge branch 'develop' into feature/rename_atm
c2d63fc 
* develop:
  Update atmosphere-lgetkf satwnd yamls (#13)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrettHoover-NOAA BrettHoover-NOAA BrettHoover-NOAA approved these changes

@danholdaway danholdaway Awaiting requested review from danholdaway

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update lgetkf satwnd yamls
3 participants
@RussTreadon-NOAA @BrettHoover-NOAA @danholdaway