Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BMI Initialize leaks file handle #67

Closed
hellkite500 opened this issue Sep 21, 2022 · 0 comments · Fixed by #68
Closed

BMI Initialize leaks file handle #67

hellkite500 opened this issue Sep 21, 2022 · 0 comments · Fixed by #68

Comments

@hellkite500
Copy link
Member

The initialization code for BMI opens the config file but never closes it. This can lead to file handle exhaustion on a system and cause crashes (in the case of ngen which initializes many independent model instances).

Current behavior

Opens config file, never closes it.

Expected behavior

Opens config file, closes it when done reading.

Steps to replicate behavior (include URLs)

  1. Best seen running ngen with large number of CFE bmi instances (greater than the number of allowed open files on the system), it will crash on most systems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant