Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More dict functions should warn #7

Closed
NOhs opened this issue Jan 18, 2019 · 1 comment
Closed

More dict functions should warn #7

NOhs opened this issue Jan 18, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@NOhs
Copy link
Owner

NOhs commented Jan 18, 2019

The following functions do not work as expected:

pop(key)

should return the correct value and also warn if a deprecated key is used.

clear()

should remove the deprecated lookup dict.

copy()

should return a dict that still warns

del my_dict[deprecated_key]

should warn before removing correctly

key in dict

should return the correct value (true in case of a deprecated key) and warn

items(), keys(), values()

are also not supported as of now, they do not contain the old keys

__iter__

should also be adapted, currently it does not yield a list with the old key and also does not warn.

@NOhs NOhs added the enhancement New feature or request label Jan 18, 2019
@NOhs NOhs self-assigned this Jan 18, 2019
@NOhs
Copy link
Owner Author

NOhs commented Feb 1, 2019

Fixed with #10

@NOhs NOhs closed this as completed Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant